[Bug 17924] New: Fix error in password recovery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Bug ID: 17924 Summary: Fix error in password recovery Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org To reproduce: - Set OpacResetPassword = allowed - Make sure you have a user with a username and email - Go to the OPAC and make sure you are not logged in - Click on the "Forgot your password?" link - Fill in "Login" and "Email" and click on "Submit" You will get an error that says: Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 142. Adding "use C4::Letters" to Koha/Patron/Password/Recovery.pm fixes this. Patch coming in a sec. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 59094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59094&action=edit Bug 17924 - Fix error in password recovery To test: - Set OpacResetPassword = allowed - Make sure you have a user with a username and email - Go to the OPAC and make sure you are not logged in - Click on the "Forgot your password?" link - Fill in "Login" and "Email" and click on "Submit" - You will get an error that says: Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 142. - Apply the patch - The steps above will have added your user to the borrower_password_recovery table in the database. Delete it from there to make sure you start a fresh reset request. - Repeat the steps above and notice that the error is gone. You should get a nice message instead that says "An email has been sent to [your email]". - Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Zoe Schoeler <crazy.mental.onion@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Zoe Schoeler <crazy.mental.onion@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59094|0 |1 is obsolete| | --- Comment #2 from Zoe Schoeler <crazy.mental.onion@gmail.com> --- Created attachment 59132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59132&action=edit Bug 17924 - Fix error in password recovery To test: - Set OpacResetPassword = allowed - Make sure you have a user with a username and email - Go to the OPAC and make sure you are not logged in - Click on the "Forgot your password?" link - Fill in "Login" and "Email" and click on "Submit" - You will get an error that says: Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 142. - Apply the patch - The steps above will have added your user to the borrower_password_recovery table in the database. Delete it from there to make sure you start a fresh reset request. - Repeat the steps above and notice that the error is gone. You should get a nice message instead that says "An email has been sent to [your email]". - Sign off Signed-off-by: Zoe Schoeler <crazy.mental.onion@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59132|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 59233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59233&action=edit Bug 17924 - Fix error in password recovery To test: - Set OpacResetPassword = allowed - Make sure you have a user with a username and email - Go to the OPAC and make sure you are not logged in - Click on the "Forgot your password?" link - Fill in "Login" and "Email" and click on "Submit" - You will get an error that says: Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 142. - Apply the patch - The steps above will have added your user to the borrower_password_recovery table in the database. Delete it from there to make sure you start a fresh reset request. - Repeat the steps above and notice that the error is gone. You should get a nice message instead that says "An email has been sent to [your email]". - Sign off Signed-off-by: Zoe Schoeler <crazy.mental.onion@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- I don't actually get the error, but better to add the use explicitly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Magnus! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org