[Bug 17879] New: Possible to upload images with no image name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Bug ID: 17879 Summary: Possible to upload images with no image name Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org This is a problem because the image name is used in the patron card layout editor, and if a person uploads a bunch of images with no names then it will be difficult to tell which image is which. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 58788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58788&action=edit Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |aleishaamohia@hotmail.com |u | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58788|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 58795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58795&action=edit Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58795|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58798&action=edit Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |minor --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Reclassifying this to be a bug - This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org