[Bug 14920] New: Remove C4::Dates from circ/reserveratios.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Bug ID: 14920 Summary: Remove C4::Dates from circ/reserveratios.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org This patch removes C4::Dates from circ/reserveratios.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 42948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42948&action=edit Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |veron@veron.ch Blocks| |14918 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14918 |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42948|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 42949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42949&action=edit Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42949|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 42950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42950&action=edit Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |In Discussion --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Marc Datepicker fails in refine results. This is the error launched: The 'day' parameter ("32") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback at /usr/lib/perl5/DateTime.pm line 199 DateTime::new(undef, 'hour', 0, 'minute', 0, 'second', 0, 'month', 10, ...) called at /home/koha/kohaclone/Koha/DateUtils.pm line 164 Koha::DateUtils::dt_from_string('2014-10-32') called at /home/koha/kohaclone/circ/reserveratios.pl line 87 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 --- Comment #5 from Marc Véron <veron@veron.ch> --- Hi Héctor, thank you for testing! I refactured the date handling. Patch follows. Can you please test again? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42950|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 43358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43358&action=edit Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 43360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43360&action=edit Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Prevent to insert invalid dates in opac-memberentry.tt. To test 1) Apply last patch (interactive) 2) Goto 'your personal details in opac' and modify date of birth with 2015-10-32 3) Goto staff in Home > Patrons requesting modifications, at the bottom of screen this redirect to members/members-update.pl and you get noticed that the date sent is '0000-00-00' 4) Apply patch 5) Go to 'your personal details in opac' (opac/opac-memberentry.pl) observe that field is readonly and patrons can't insert invalid dates. Field 'Date of birth' in Opac is now restricted to date picker. Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43358|0 |1 is obsolete| | --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 43361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43361&action=edit [SIGNED-OFF] Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with dateformat syspref, datepiker Ok -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43360|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Comment on attachment 43360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43360 Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Wrong bug number. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43361|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43376&action=edit Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with dateformat syspref, datepiker Ok Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43377&action=edit Bug 14920: Simplify the date management on reserveratios Note that the previous patch was wrong, the start date defaulted to yesterday, the original behavior is to default to last year. This patch removes some unecessary variable declarations and tests. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org