[Bug 14841] New: Columns settings on checkouts table have 2 bugs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Bug ID: 14841 Summary: Columns settings on checkouts table have 2 bugs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 13492 1/ The settings defined on the administration page are not taken into account 2/ The "Fines" column does not appear in the field list. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 [Bug 13492] Add location to the checkouts tables -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42635&action=edit Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42636&action=edit Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9481 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 [Bug 9481] charge not showing fines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bugs 9481 and 13492 are in 3.20.x, this should be backported. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42635|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 43102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43102&action=edit Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42636|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 43105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43105&action=edit Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43102|0 |1 is obsolete| | Attachment #43105|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43321&action=edit Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43322&action=edit [PASSED QA] Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43321|0 |1 is obsolete| | Attachment #43322|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43323&action=edit [PASSED QA] Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43324&action=edit [PASSED QA] Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org