[Bug 29845] New: Styling OverDrive buttons is difficult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Bug ID: 29845 Summary: Styling OverDrive buttons is difficult Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some librarians would like style the buttons on the Dverdrive results page differently from one another. I realized this is somewhat difficult to do at the moment because each of those buttons are built by JavaScript and don't include a unique class name or ID. Those buttons are the check-in, check-out, place hold, cancel hold, and download as buttons. If they had an ID it would make it easy to style them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129288&action=edit Bug 29845: add IDs to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold, and download as buttons, none of them contain ID's. 4. Apply patch 5. Repeat 3 again but this time they should all contain an ID which makes them much easier to style. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds ID's to the action release notes| |buttons on the OverDrive | |results page in order to | |make them easier to | |individually style. Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Using the id attribute will create situations where there are multiple identical ids on the page, which isn't allowed. Can you use a class instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129288|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129324&action=edit Bug 29845: add IDs to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold, and download as buttons, none of them contain ID's. 4. Apply patch 5. Repeat 3 again but this time they should all contain an ID which makes them much easier to style. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129324|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129332&action=edit Bug 29845: add IDs to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold, and download as buttons, none of them contain ID's. 4. Apply patch 5. Repeat 3 again but this time they should all contain an ID which makes them much easier to style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As I can't test Overdrive I am a bit hesitant to try my hands on the rebase: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29845: add IDs to overdrive results action buttons Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js error: Failed to merge in the changes. Patch failed at 0001 Bug 29845: add IDs to overdrive results action buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129332|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130633&action=edit Bug 29845: add classes to overdrive results action buttonswq To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130633|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130634&action=edit Bug 29845: add classes to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130634|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130662&action=edit Bug 29845: add classes to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130662|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130878&action=edit Bug 29845: add classes to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org