[Bug 27627] New: Fix invalid HTMl in OPAC results XSLT: change spans to divs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Bug ID: 27627 Summary: Fix invalid HTMl in OPAC results XSLT: change spans to divs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: kyle@bywatersolutions.com, lucas@bywatersolutions.com, testopia@bugs.koha-community.org Depends on: 27613 There are many <span>s in MARC21slim2OPACResults.xsl which contain block-level elements, which is invalid. There's no reason for these not to be converted to <div>s. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 [Bug 27613] Pipe separated online resource links are hard to customize -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This bug is revealed but not caused by Bug 27613 because it adds <ul> to these spans. The validation error in question is: Element ul not allowed as child of element span in this context. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116330&action=edit Bug 27627: Fix invalid HTMl in OPAC results XSLT: change spans to divs This patch modifies the XSL template for OPAC search results in order to improve HTML validation: Changing some <span>s to <div>s will prevent an error when those <span>s contain block-level elements. To test, apply the patch and restart_all if necessary. - Confirm that OPACXSLTResultsDisplay is set to "default" - Perform a catalog search in the OPAC. - Validate the page source and confirm that there are no errors about "Element ul not allowed as child of element span in this context" Note: another patch will address other validation errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix invalid HTMl in OPAC |Fix invalid HTML in OPAC |results XSLT: change spans |results XSLT: change spans |to divs |to divs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116330|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 116332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116332&action=edit Bug 27627: Fix invalid HTMl in OPAC results XSLT: change spans to divs This patch modifies the XSL template for OPAC search results in order to improve HTML validation: Changing some <span>s to <div>s will prevent an error when those <span>s contain block-level elements. To test, apply the patch and restart_all if necessary. - Confirm that OPACXSLTResultsDisplay is set to "default" - Perform a catalog search in the OPAC. - Validate the page source and confirm that there are no errors about "Element ul not allowed as child of element span in this context" Note: another patch will address other validation errors. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Owen, I signed off on this one too hastily. There is still one <span>, .results_summary .type that should be a <div> Also, the display is now altered as each of the elements 'results_material_type', 'results_format', 'results_contents_literary' now displaying block instead of displaying inline https://snipboard.io/FNIiRL.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 116334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116334&action=edit Bug 27627: (follow-up) Change one more span to div -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 116438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116438&action=edit Bug 27627: (follow-up) change div nested inside .type to span -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk --- Comment #7 from Henry Bolshaw <bolshawh@parliament.uk> --- Hi Lucas and Owen, does this need signing off again? Have the issues Lucas raised been fixed by the follow-ups? "Owen, I signed off on this one too hastily. There is still one <span>, .results_summary .type that should be a <div> Also, the display is now altered as each of the elements 'results_material_type', 'results_format', 'results_contents_literary' now displaying block instead of displaying inline" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Henry Bolshaw from comment #7)
Hi Lucas and Owen, does this need signing off again? Have the issues Lucas raised been fixed by the follow-ups?
"Owen, I signed off on this one too hastily. There is still one <span>, .results_summary .type that should be a <div>
Also, the display is now altered as each of the elements 'results_material_type', 'results_format', 'results_contents_literary' now displaying block instead of displaying inline"
I think these sound like good catches - setting FQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116332|0 |1 is obsolete| | Attachment #116334|0 |1 is obsolete| | Attachment #116438|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127455&action=edit Bug 27627: Fix invalid HTMl in OPAC results XSLT: change spans to divs This patch modifies the XSL template for OPAC search results in order to improve HTML validation: Changing some <span>s to <div>s will prevent an error when those <span>s contain block-level elements. To test, apply the patch and restart_all if necessary. - Confirm that OPACXSLTResultsDisplay is set to "default" - Perform a catalog search in the OPAC. - Validate the page source and confirm that there are no errors about "Element ul not allowed as child of element span in this context" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127455|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127544&action=edit Bug 27627: Fix invalid HTMl in OPAC results XSLT: change spans to divs This patch modifies the XSL template for OPAC search results in order to improve HTML validation: Changing some <span>s to <div>s will prevent an error when those <span>s contain block-level elements. To test, apply the patch and restart_all if necessary. - Confirm that OPACXSLTResultsDisplay is set to "default" - Perform a catalog search in the OPAC. - Validate the page source and confirm that there are no errors about "Element ul not allowed as child of element span in this context" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as expected now, nice bit of tidying up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Right now waiting for its dependency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127544|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130976&action=edit Bug 27627: Fix invalid HTMl in OPAC results XSLT: change spans to divs This patch modifies the XSL template for OPAC search results in order to improve HTML validation: Changing some <span>s to <div>s will prevent an error when those <span>s contain block-level elements. To test, apply the patch and restart_all if necessary. - Confirm that OPACXSLTResultsDisplay is set to "default" - Perform a catalog search in the OPAC. - Validate the page source and confirm that there are no errors about "Element ul not allowed as child of element span in this context" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- We should do the same in OPAC details XSLT no ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Bug 27627 depends on bug 27613, which changed state. Bug 27613 Summary: Pipe separated online resource links are hard to customize (OPAC) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org