[Bug 21242] New: Modification log redirects you to circulation with no borrower if 'Object' field is not populated with borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Bug ID: 21242 Summary: Modification log redirects you to circulation with no borrower if 'Object' field is not populated with borrowernumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The code seems to make the assumption that if we come from circ, we only want to view the borrowers info, however, it provides the full form, indicating you can search for more info. To recreate: 1 - Pull up a patron 2 - Click 'Modification log' 3 - You see info about patron 4 - Change the form, moving Object to Info 5 - You are sent to a blank circ page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77975&action=edit Bug 21242: If not searching for patron, move to log viewer To test: 1 - Bring up a patron 2 - Click 'Modification log' 3 - Note you get borrower info 4 - Move the object field into info field 5 - Submit 6 - You are now on the 'Log viewer' page with admin options, not borrower circ options -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77975|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77990&action=edit Bug 21242: If not searching for patron, move to log viewer To test: 1 - Bring up a patron 2 - Click 'Modification log' 3 - Note you get borrower info 4 - Move the object field into info field 5 - Submit 6 - You are now on the 'Log viewer' page with admin options, not borrower circ options Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- And what about making "object" read-only if viewing logs from a given patron? https://snag.gy/rqolXT.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77994&action=edit [ALTERNATIVE-PATCH] Bug 21242: Make object's input read-only when viewing patron's logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, Owen, what about this alternative patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
Nick, Owen, what about this alternative patch?
Hmm...this still allows for odd things - the borrowernumber is locked, but I can change the moduel to "Catalog", then I get the info for the biblio with the same number, and I have circ options with no patron. If we want to go that route I would suggest to disable the whole form and replacing it with a link to the log viewer I don't hate my patch though :-b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21634 Assignee|jonathan.druart@bugs.koha-c |nick@bywatersolutions.com |ommunity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19791 Status|In Discussion |Signed Off --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #6)
I don't hate my patch though :-b
Ok, let's ask for another QA point of view. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 [Bug 21634] "Circulation" option is lost when viewing patron's logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a hard one. The basic problem seems to be that we use the log viewer in a specific context: related to one patron. But as it's a general search form there is no guarantee that people won't search for other things as well. I don't like the alternative patch so much as it feels too limiting without reason. Why do we not allow it to change and force users to make more clicks if it's the same form they get when coming from tools? I don't have a perfect solution, but I feel Nick's patch is an improvement over the current behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77990|0 |1 is obsolete| | Attachment #77994|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81418&action=edit Bug 21242: If not searching for patron, move to log viewer To test: 1 - Bring up a patron 2 - Click 'Modification log' 3 - Note you get borrower info 4 - Move the object field into info field 5 - Submit 6 - You are now on the 'Log viewer' page with admin options, not borrower circ options Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Bug 21242 depends on bug 21634, which changed state. Bug 21634 Summary: "Circulation" option is lost when viewing patron's logs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |18789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 [Bug 18789] Send a Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Patch depends on Bug 18789. Since it is a minor impact, I choose not to push to 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org