https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81023&action=edit Bug 21634: Keep "circulation" module selected when viewing patron's logs To recreate: - View a patron detail page - Click "Modification log" - Notice that the url has "modules=MEMBERS&modules=circulation", but the "Circulation" option is not selected in the "Modules" dropdown list. This is because of uppercase vs lowercase. The bug: - Right after you click "Modification log" you will see all the "members" and "circulation" logs - Submit the form without changing any input/select from the form => Now you only see the "members" logs. Test plan: - Apply the patch - Click "Modification log" - Notice that the url now contains "modules=MEMBERS&modules=CIRCULATION" - Submit the form without changing any input/select from the form => Now you have the "members" and "circulation" modules selected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- There is a conflict when the patch is applied. A rebase is necessary. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81023|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81335&action=edit Bug 21634: Keep "circulation" module selected when viewing patron's logs To recreate: - View a patron detail page - Click "Modification log" - Notice that the url has "modules=MEMBERS&modules=circulation", but the "Circulation" option is not selected in the "Modules" dropdown list. This is because of uppercase vs lowercase. The bug: - Right after you click "Modification log" you will see all the "members" and "circulation" logs - Submit the form without changing any input/select from the form => Now you only see the "members" logs. Test plan: - Apply the patch - Click "Modification log" - Notice that the url now contains "modules=MEMBERS&modules=CIRCULATION" - Submit the form without changing any input/select from the form => Now you have the "members" and "circulation" modules selected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81336|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81401&action=edit Bug 21634: Keep "circulation" module selected when viewing patron's logs To recreate: - View a patron detail page - Click "Modification log" - Notice that the url has "modules=MEMBERS&modules=circulation", but the "Circulation" option is not selected in the "Modules" dropdown list. This is because of uppercase vs lowercase. The bug: - Right after you click "Modification log" you will see all the "members" and "circulation" logs - Submit the form without changing any input/select from the form => Now you only see the "members" logs. Test plan: - Apply the patch - Click "Modification log" - Notice that the url now contains "modules=MEMBERS&modules=CIRCULATION" - Submit the form without changing any input/select from the form => Now you have the "members" and "circulation" modules selected. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.