[Bug 19817] New: Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Bug ID: 19817 Summary: Merge local and online documentations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: Documentation Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org We are currently maintaining a local (help/* files) and online (https://koha-community.org/manual) documentations. They must be merged to ease the maintainability and improve the relevance. The online manual has been improved greatly the last months and the obvious solution would be to point to it from the different Koha installations. Here is the different steps I have in mind: - Remove existing local documentation - Point to the relevant pages of the online documentation - Make the online documentation configurable to add the ability to point to a local copy (for offline access) - Re-add the ability to edit the manual It would make sense to have a koha-manual package depending on sphinx and copy the related .rst files (depending on the Koha version). Then a script will be provided (koha-build-manual) to regenerate the manual (after an update for instance) in different languages. For the local edition we could imagine to add add local commits when a change is made. Advanced users/administrators will then need to rebase and eventually fix the conflicts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 19381 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz, | |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69807&action=edit Bug 19817: Redirect to the online manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69808&action=edit Bug 19817: Remove local help files + edit help feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70131&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70132&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70133&action=edit Bug 19817: Add new permission edit_help Change in existing behaviour! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |laurence.rault@biblibre.com | |, ldjamison@marywood.edu, | |m.de.rooy@rijksmuseum.nl, | |oleonard@myacpl.org, | |veron@veron.ch --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Next step is to re-add the ability to "edit the manual". I would suggest to remove the possibility to edit the manual, but allow to create new pages (which will not be erased on update). I need to know what are the different use cases and needs. We need also to think about an ergonomic way to manage these additional help files. For instance: in the top right of the staff pages we will have a "Help" group buttons with Link to the official manual | Add a new page And when new pages are created: Link to the official manual | Additional pages 1..N | Add a new page The additional pages would be linked to a specific page of the staff interface (see the mapping in Koha::Manual) Does it make sense? Other ideas/opinions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18472 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #7)
Next step is to re-add the ability to "edit the manual". I would suggest to remove the possibility to edit the manual, but allow to create new pages (which will not be erased on update).
I need to know what are the different use cases and needs.
Possible use cases I could see for local help files: - Being able to explain custom fields like authorised values, patron attributes etc. - Being able to explain how to use collections, locations, item types - Offer local help for cataloguing like explanations for fields and subfields, internal standards and agreements
We need also to think about an ergonomic way to manage these additional help files. For instance: in the top right of the staff pages we will have a "Help" group buttons with Link to the official manual | Add a new page And when new pages are created: Link to the official manual | Additional pages 1..N | Add a new page
The additional pages would be linked to a specific page of the staff interface (see the mapping in Koha::Manual)
Does it make sense? Other ideas/opinions?
That makes sense to me. I think having a HTML based editor would be better than .rst for the local help files and that we should store them in the database. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, can you please rebase? I tried but it got a bit chaotic. I think you are missing the change to koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc for the new permission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69807|0 |1 is obsolete| | Attachment #69808|0 |1 is obsolete| | Attachment #70131|0 |1 is obsolete| | Attachment #70132|0 |1 is obsolete| | Attachment #70133|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73523&action=edit Bug 19817: Redirect to the online manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73524&action=edit Bug 19817: Remove local help files + edit help feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73525&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73526&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73527&action=edit Bug 19817: Add new permission edit_help Change in existing behaviour! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Done, note that the last patch does nothing (new permission is not used). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, some thoughts: 1) sub _get_base_url doesn't look quite right yet. a) It hardcodes en. Ideally we should try to check for the existence of a translated manual and use that, with a fallback to en. If we can't do that, we'll maybe need to add a pref where you can add the lanugage codes to use. b) For the local manual URL you combine: C4::Context->preference('staffClientBaseURL') . $KohaManualBaseURL; I think it might be good to allow for a full URL in KohaManualBaseURL. That way you could have the help on the same server or at another location. 2) If the permission doesn't work yet, I would not include it :) 3) The manual layout doesn't work well in the small pop up. I wonder if there is a way to leave off the side navigation, but probably we can just make the window a bit wider. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@joensuu.fi --- Comment #17 from paxed <pasi.kallinen@joensuu.fi> --- The manual should first try to be in the currently used UI language, and then whatever other fallbacks there are (with "en" as the last, hardcoded one) or if fallbacks aren't feasible, the non-existing-manual page on koha-community could show something like "The manual does not exist for the language $foo. You can read the [manual in english], or [translate the manual]", with links to the actual manual in english and to the wiki article on how to start translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15003 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73527|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73651&action=edit Bug 19817: Add pref KohaManualLanguage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73652&action=edit Bug 19817: Open the manual in a new window, not a popup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #16)
Hi Jonathan,
some thoughts:
1) sub _get_base_url doesn't look quite right yet. a) It hardcodes en. Ideally we should try to check for the existence of a translated manual and use that, with a fallback to en. If we can't do that, we'll maybe need to add a pref where you can add the lanugage codes to use.
I have added a patch to add a new pref KohaManualLanguage
b) For the local manual URL you combine: C4::Context->preference('staffClientBaseURL') . $KohaManualBaseURL; I think it might be good to allow for a full URL in KohaManualBaseURL. That way you could have the help on the same server or at another location.
The concatenation is done only if the pref does not start with '/', so you can use a value starting with 'http://'
2) If the permission doesn't work yet, I would not include it :)
Patch removed.
3) The manual layout doesn't work well in the small pop up. I wonder if there is a way to leave off the side navigation, but probably we can just make the window a bit wider.
Done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the pref is too limiting for a lot of multilingual instances still. Could we make it work like that? Make the manual pref a list of language codes to existing manuals. Try to open the manual in the current GUI language first using the list to verify if it exists. If it doesn't match one of the language codes, use the first code in the list as a fallback. We could start the list off with all the existing manuals and first language en, but it would be easy to add new ones. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73872&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73872|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73877&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #24 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 73523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73523 Bug 19817: Redirect to the online manual Review of attachment 73523: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19817&attachment=73523) ----------------------------------------------------------------- ::: help.pl @@ +1,3 @@
#!/usr/bin/perl
+# Copyright 2017 Koha Development team
I would prefer 2010-2017 or even 2010,2017 so we do not lose track of the original date in quickly obvious statement. (https://www.plagiarismtoday.com/2011/11/08/how-to-write-a-copyright-notice/) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #25 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 73525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73525 Bug 19817: Make the location of the manual configurable - KohaManualBaseURL Review of attachment 73525: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19817&attachment=73525) ----------------------------------------------------------------- The http URL redirects to an https one, so it makes more sense to use https immediately. ::: help.pl @@ +39,2 @@
# FIXME /en/ must be configurable (or guessed) +my $KohaManualBaseURL = C4::Context->preference('KohaManualBaseURL') || 'http://koha-community.org/manual';
please use https. ::: installer/data/mysql/atomicupdate/bug_19817.sql @@ +1,2 @@
+INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) +VALUES ('KohaManualBaseURL','http://koha-community.org/manual/','','Where is the Koha manual/documentation located?','Free');
please use https. ::: installer/data/mysql/sysprefs.sql @@ +238,4 @@
('itemBarcodeInputFilter','','whitespace|T-prefix|cuecat|libsuite8|EAN13','If set, allows specification of a item barcode input filter','Choice'), ('itemcallnumber','082ab',NULL,'The MARC field/subfield that is used to calculate the itemcallnumber (Dewey would be 082ab or 092ab; LOC would be 050ab or 090ab) could be 852hi from an item record','free'), ('KohaAdminEmailAddress','root@localhost','','Define the email address where patron modification requests are sent','free'), +('KohaManualBaseURL','http://koha-community.org/manual/','','Where is the Koha manual/documentation located?','Free'),
please use https. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref @@ +394,5 @@
+ Manual: + - + - Location of the Koha manual + - pref: KohaManualBaseURL + - You can specify the location of the Koha manual to use. By default it is http://koha-community.org/manual/
please use https. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #26 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 73526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73526 Bug 19817: Move code to Koha::Manual to make it testable and reusable Review of attachment 73526: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19817&attachment=73526) ----------------------------------------------------------------- I may have missed commenting on other changes which had just http in them. ::: Koha/Manual.pm @@ +17,5 @@
+} + +sub _get_base_url { + # FIXME /en/ must be configurable (or guessed) + my $KohaManualBaseURL = C4::Context->preference('KohaManualBaseURL') || 'http://koha-community.org/manual';
Please use https. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #27 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 73651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73651 Bug 19817: Add pref KohaManualLanguage Review of attachment 73651: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19817&attachment=73651) ----------------------------------------------------------------- ::: Koha/Manual.pm @@ +20,2 @@
my $KohaManualBaseURL = C4::Context->preference('KohaManualBaseURL') || 'http://koha-community.org/manual'; + my $KohaManualLanguage = C4::Context->preference('KohaManualLanguage') || 'en';
If there are multiple languages selected, this will be ugly and broken, I think (haven't tested yet). ::: installer/data/mysql/sysprefs.sql @@ +47,4 @@
('AnonSuggestions','0',NULL,'Set to enable Anonymous suggestions to AnonymousPatron borrowernumber','YesNo'), ('AnonymousPatron','0',NULL,'Set the identifier (borrowernumber) of the anonymous patron. Used for Suggestion and reading history privacy',''), ('ArticleRequests', '0', NULL, 'Enables the article request feature', 'YesNo'), +('ArticleRequestsMandatoryFields', '', NULL, 'Comma delimited list of required fields for bibs where article requests rule = ''yes''', 'Choice'),
Was this another bug fix someewhere? multiple->Choice and removal of end of line whitespace. @@ +239,4 @@
('itemcallnumber','082ab',NULL,'The MARC field/subfield that is used to calculate the itemcallnumber (Dewey would be 082ab or 092ab; LOC would be 050ab or 090ab) could be 852hi from an item record','free'), ('KohaAdminEmailAddress','root@localhost','','Define the email address where patron modification requests are sent','free'), ('KohaManualBaseURL','http://koha-community.org/manual/','','Where is the Koha manual/documentation located?','Free'), +('KohaManualLanguage','en','en|ar|cs|es|fr|it|pt_BR|tr|zh_TW','What is the language of the online manual you want to use?','multiple'),
I like the idea of calling up the language which is currently selected, if possible. However, multiple differs from Choice used in the atomic update. Need to correct somehow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #28 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 73524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73524 Bug 19817: Remove local help files + edit help feature Review of attachment 73524: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19817&attachment=73524) ----------------------------------------------------------------- ::: t/db_dependent/00-strict.t @@ +19,4 @@
'catalogue', 'cataloguing', 'changelanguage.pl', 'circ', 'debian', 'docs', + 'errors', 'fix-perl-path.PL',
But help.pl is no longer listed. @@ -19,5 @@
'catalogue', 'cataloguing', 'changelanguage.pl', 'circ', 'debian', 'docs', - 'edithelp.pl', 'errors', - 'fix-perl-path.PL', 'help.pl',
help.pl is still here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #29 from M. Tompsett <mtompset@hotmail.com> --- Preliminary testing was generally positive. Though, I think these points should be discussed, if not addressed, before considering sign off. - https vs http in the urls used. - choice vs multiple in the added KohaManualLanguage sys pref - help.pl removed from 00-strict.t - postfix slash the default URL creates a // in the URL. remove the '/' in the URL building in Koha::Manual? build smarter? kshell cd misc/translator for i in `ls po | cut -f1-2 -d'-' | sed -e "s#-opac##g" | sed -e "s#-pref.po##g" | sed -e "s#-staff##g" | sed -e "s#-marc##g" | sort -u`; do echo $i;perl translate install $i;done -- noisy! Though, I suspect correct. perhaps help po files need to be deleted too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73523|0 |1 is obsolete| | Attachment #73524|0 |1 is obsolete| | Attachment #73525|0 |1 is obsolete| | Attachment #73526|0 |1 is obsolete| | Attachment #73651|0 |1 is obsolete| | Attachment #73652|0 |1 is obsolete| | Attachment #73877|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73931&action=edit Bug 19817: Redirect to the online manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73932&action=edit Bug 19817: Remove local help files + edit help feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73933&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73934&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73935&action=edit Bug 19817: Add pref KohaManualLanguage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73936&action=edit Bug 19817: Open the manual in a new window, not a popup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73937&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73938&action=edit Bug 19817: use https instead of http the https version was not working when I wrote the first patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #29)
Preliminary testing was generally positive. Though, I think these points should be discussed, if not addressed, before considering sign off.
Thanks for catching those things. I have marked as obsolete the other comments (they are the verbose version of the next 5 lines)
- https vs http in the urls used.
Yes, in the meanwhile I have asked rangi to enable https on the manual (was not there before).
- choice vs multiple in the added KohaManualLanguage sys pref
It's a choice indeed.
- help.pl removed from 00-strict.t
Re-added
- postfix slash the default URL creates a // in the URL. remove the '/' in the URL building in Koha::Manual? build smarter?
I do not understand what you suggest here.
kshell cd misc/translator for i in `ls po | cut -f1-2 -d'-' | sed -e "s#-opac##g" | sed -e "s#-pref.po##g" | sed -e "s#-staff##g" | sed -e "s#-marc##g" | sort -u`; do echo $i;perl translate install $i;done -- noisy! Though, I suspect correct. perhaps help po files need to be deleted too?
I do not think so, should be deleted on releasing (there are certainly other things to do in the release scripts). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patches don't apply right now - can you take a look? Looking at the last comments: 1) Removing the po files on release date would make sense to me. 2)
- postfix slash the default URL creates a // in the URL. remove the '/' in the URL building in Koha::Manual? build smarter?
I think we expect people to get it right for BaseURLs already. so no need to be more strict here. (Do not enter trailing slash) 3)
- choice vs multiple in the added KohaManualLanguage sys pref
It's a choice indeed.
Hm, what I was thinking about was a multiple indeed. We usually have at least German and English installed for staff, often Spanish and French now too. I would like to use the pref to indicate existing manuals for staff activated languages. So when I open the help and it matches one of the selected languages I get the right language manual. Makes sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73931|0 |1 is obsolete| | Attachment #73932|0 |1 is obsolete| | Attachment #73933|0 |1 is obsolete| | Attachment #73934|0 |1 is obsolete| | Attachment #73935|0 |1 is obsolete| | Attachment #73936|0 |1 is obsolete| | Attachment #73937|0 |1 is obsolete| | Attachment #73938|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74567&action=edit Bug 19817: Redirect to the online manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74568&action=edit Bug 19817: Remove local help files + edit help feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74569&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74570&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74571&action=edit Bug 19817: Add pref KohaManualLanguage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74572&action=edit Bug 19817: Open the manual in a new window, not a popup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74573&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74574&action=edit Bug 19817: use https instead of http the https version was not working when I wrote the first patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #39)
3)
- choice vs multiple in the added KohaManualLanguage sys pref
It's a choice indeed.
Hm, what I was thinking about was a multiple indeed. We usually have at least German and English installed for staff, often Spanish and French now too. I would like to use the pref to indicate existing manuals for staff activated languages. So when I open the help and it matches one of the selected languages I get the right language manual. Makes sense?
The pref is the default value. If the pref is set to English and the interface is in Spanish, the manual will be in Spanish. If the interface is in Esperanto, the manual will be in English (the manual is not translated in Esperanto, yet). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What if the selected language doesn't have an existing manual? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- My idea was to use the pref as a white list of existing manuals, because I was not sure we can tell and not have it end up on an error page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- To me it does not make sense to make it a free text. We could retrieve the available languages from the syspref options, it will avoid to have it hardcoded in the code. And then a quick SQL query will allow to extend the list. I do not think it should be a blocker anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74567|0 |1 is obsolete| | Attachment #74568|0 |1 is obsolete| | Attachment #74569|0 |1 is obsolete| | Attachment #74570|0 |1 is obsolete| | Attachment #74571|0 |1 is obsolete| | Attachment #74572|0 |1 is obsolete| | Attachment #74573|0 |1 is obsolete| | Attachment #74574|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74644&action=edit Bug 19817: Redirect to the online manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74645&action=edit Bug 19817: Remove local help files + edit help feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74646&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74647&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74648&action=edit Bug 19817: Add pref KohaManualLanguage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74649&action=edit Bug 19817: Open the manual in a new window, not a popup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74650&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74651&action=edit Bug 19817: use https instead of http the https version was not working when I wrote the first patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20706 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74644|0 |1 is obsolete| | Attachment #74645|0 |1 is obsolete| | Attachment #74646|0 |1 is obsolete| | Attachment #74647|0 |1 is obsolete| | Attachment #74648|0 |1 is obsolete| | Attachment #74649|0 |1 is obsolete| | Attachment #74650|0 |1 is obsolete| | Attachment #74651|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75370&action=edit Bug 19817: Redirect to the online manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75371&action=edit Bug 19817: Remove local help files + edit help feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75372&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75373&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75374&action=edit Bug 19817: Add pref KohaManualLanguage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75375&action=edit Bug 19817: Open the manual in a new window, not a popup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75376&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75377&action=edit Bug 19817: use https instead of http the https version was not working when I wrote the first patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20706 | Depends on| |20706 --- Comment #68 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Rebased on top of bug 20706. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #69 from Owen Leonard <oleonard@myacpl.org> --- Is there more of a test plan than "click the help link on a bunch of pages?" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|oleonard@myacpl.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #69)
Is there more of a test plan than "click the help link on a bunch of pages?"
Yes, definitely. This change is more a philosophical changes, we are going to remove the local manual. To test the whole patchset you will need to play with KohaManualBaseURL and KohaManualLanguage and make sure the links are still working and redirect to the correct url. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Bug 19817 depends on bug 20706, which changed state. Bug 20706 Summary: Fix links to help files for changed file structure (removed numbering on files) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #71 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I had a bit of trouble applying the patch. I had to add member-flags.tt and then continue applying the patch. I don't know if that's normal or not. I went to Global system preferences and clicked on the tab for circulation. When I clicked help, the manual was at the beginning of the sysprefs section. I don't know if it's possible at all to point to the right sub-section? It's just that are sooooo many system preferences... My KohaManualLanguage is on Arabic by default. I'm guessing it's the first language in the list, but if I don't change it will this be the default? Should we put English by default instead of Arabic? I also don't see the edit button mentioned in comment 7. Was that implemented or just an idea for a future development? It could be a second patch. People don't currently have the ability to modify from the staff interface, so it wouldn't necessarily be a step back. More advanced users can still use their own help files. I wasn't able to test switching languages because my master is only installed in English. It's a great development! It will be much easier to translate, no need to translate the help file, just the manual. It will also be more uniform. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Caroline Cyr La Rose from comment #71)
I had a bit of trouble applying the patch. I had to add member-flags.tt and then continue applying the patch. I don't know if that's normal or not.
Yes, conflict. I am going to re-attached a rebased version of these patches.
I went to Global system preferences and clicked on the tab for circulation. When I clicked help, the manual was at the beginning of the sysprefs section. I don't know if it's possible at all to point to the right sub-section? It's just that are sooooo many system preferences...
It should be the same behaviour as prior to the patch. We can imagine a link close to each pref to point to the dedicated section of the manual. TODO later ;)
My KohaManualLanguage is on Arabic by default. I'm guessing it's the first language in the list, but if I don't change it will this be the default? Should we put English by default instead of Arabic?
I guess you did not execute the updatedatabase.pl script. The default value is "en".
I also don't see the edit button mentioned in comment 7. Was that implemented or just an idea for a future development? It could be a second patch. People don't currently have the ability to modify from the staff interface, so it wouldn't necessarily be a step back. More advanced users can still use their own help files.
The original plan was to provide a full help system, local editing (on top of git repository), etc. I have asked several time on the mailing lists and during IRC meetings to get feedbacks and ideas. I did not get answers and I am no longer willing to provide such enhancements. Maybe later...
I wasn't able to test switching languages because my master is only installed in English.
You can install a couple with: sudo koha-translate --install fr-CA --dev kohadev sudo koha-translate --install it-IT --dev kohadev
It's a great development! It will be much easier to translate, no need to translate the help file, just the manual. It will also be more uniform.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75370|0 |1 is obsolete| | Attachment #75371|0 |1 is obsolete| | Attachment #75372|0 |1 is obsolete| | Attachment #75373|0 |1 is obsolete| | Attachment #75374|0 |1 is obsolete| | Attachment #75375|0 |1 is obsolete| | Attachment #75376|0 |1 is obsolete| | Attachment #75377|0 |1 is obsolete| | --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76151&action=edit Bug 19817: Redirect to the online manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #74 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76152&action=edit Bug 19817: Remove local help files + edit help feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76153&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76154&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76155&action=edit Bug 19817: Add pref KohaManualLanguage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76156&action=edit Bug 19817: Open the manual in a new window, not a popup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76157&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76158&action=edit Bug 19817: use https instead of http the https version was not working when I wrote the first patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 11115 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76151|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77791&action=edit Bug 19817: Redirect to the online manual Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76152|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77792&action=edit Bug 19817: Remove local help files + edit help feature Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76153|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77793&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76154|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77794&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76155|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77795&action=edit Bug 19817: Add pref KohaManualLanguage Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76156|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77797&action=edit Bug 19817: Open the manual in a new window, not a popup Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76157|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77798&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76158|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77799&action=edit Bug 19817: use https instead of http the https version was not working when I wrote the first patches Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All seems to work for me, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #91 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is something not quite right with the default URL and mappings. We have since removed the chapter numbers from the file names in Sphinx, but the patches seem to link to an outdated version of the manual: https://koha-community.org/manual/18.05/en/html/09_acquisitions.html#acquisi... vs correct: https://koha-community.org/manual/18.05/en/html/acquisitions.html#acquisitio... Have to stop working on this for now, hope to be back later today. If you beat me to fixing this. I'd not be unhappy about it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: t/db_dependent/00-strict.t fails for me, but because of Overdrive. How to fix? CPAN? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #93 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77932&action=edit Bug 19817: Remove numbering from chapter file names See commit 8ad495abf1e42c5e73c5cb62ec32e1a54d16f8e8 Remove numbering from chapter file names from koha-manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #94 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #92)
Also: t/db_dependent/00-strict.t fails for me, but because of Overdrive. How to fix? CPAN?
I guess so, yes. But for sure you get it against master as well, it's not related with those patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #94)
(In reply to Katrin Fischer from comment #92)
Also: t/db_dependent/00-strict.t fails for me, but because of Overdrive. How to fix? CPAN?
I guess so, yes. But for sure you get it against master as well, it's not related with those patches.
I know it's not related - but this patch set changes the test and the failure keeps me from testing that part. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77791|0 |1 is obsolete| | --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77942&action=edit Bug 19817: Redirect to the online manual Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77792|0 |1 is obsolete| | --- Comment #97 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77943&action=edit Bug 19817: Remove local help files + edit help feature Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77793|0 |1 is obsolete| | --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77944&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77794|0 |1 is obsolete| | --- Comment #99 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77945&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77795|0 |1 is obsolete| | --- Comment #100 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77946&action=edit Bug 19817: Add pref KohaManualLanguage Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77797|0 |1 is obsolete| | --- Comment #101 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77947&action=edit Bug 19817: Open the manual in a new window, not a popup Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77798|0 |1 is obsolete| | --- Comment #102 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77948&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77799|0 |1 is obsolete| | --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77949&action=edit Bug 19817: use https instead of http the https version was not working when I wrote the first patches Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77932|0 |1 is obsolete| | --- Comment #104 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77950&action=edit Bug 19817: Remove numbering from chapter file names See commit 8ad495abf1e42c5e73c5cb62ec32e1a54d16f8e8 Remove numbering from chapter file names from koha-manual Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #105 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77951&action=edit Bug 19817: (QA follow-up) Add German manual and fix system preference help files - German language manuals were added since this patch was started - The structure of the manual was changed slightly, system preferences were moved into their own chapter To test: - Test help files display correctly for system preferences display correctly Note: Local use uses a different page than the other tabs - Test German shows up as option in KohaManualLanguage and links correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #106 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- New feature, this will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #108 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78953&action=edit Bug 19817: (follow-up) Remove local help files + edit help feature I have no idea what happened but RM did not rebase that one correctly before pushing it ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #109 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #108)
Created attachment 78953 [details] [review] Bug 19817: (follow-up) Remove local help files + edit help feature
I have no idea what happened but RM did not rebase that one correctly before pushing it ;)
What happened = The RM goofed Follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21483 [Bug 21483] Translate script displays an error about missing "help" directory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21481 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 [Bug 21481] Translation tool still references to help templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Great strides have been release notes| |taken to improve Koha's | |online documentation. This | |enhancement removes the | |outdated local help system | |from the software, opting | |instead to contextually | |link to the well maintained | |online manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7920 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 aplicacoes.dmsi@cm-portimao.pt <aplicacoes.dmsi@cm-portimao.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aplicacoes.dmsi@cm-portimao | |.pt Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #110 from aplicacoes.dmsi@cm-portimao.pt <aplicacoes.dmsi@cm-portimao.pt> --- Setting KohaManualBaseURL to https://koha-community.org/manual and using user interface language pt~PT, the help link is redirected (for example) to https://koha-community.org/manual/18.11/pt_BZ/html/systempreferences.html displaying an error page. I guess its related with a typo on line 22 in the file Manual.pm 22 my @available_languages = qw( en ar cs es fr it pt_BZ tz zh_TW ); Tested replacing the value pt_BZ by pt_BR and the link now works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #111 from Humberto Chula <aplicacoes.dmsi@cm-portimao.pt> --- Created attachment 87238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87238&action=edit Fix Portuguese manual link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This should really be added as a new bug Humberto, otherwise it's extremely easy for the maintenance team to miss it. I'll split it off for you this time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- See bug 22687 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22687 [Bug 22687] Type in Koha::Manual breaks Portuguese links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2326 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org