https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #29)
Preliminary testing was generally positive. Though, I think these points should be discussed, if not addressed, before considering sign off.
Thanks for catching those things. I have marked as obsolete the other comments (they are the verbose version of the next 5 lines)
- https vs http in the urls used.
Yes, in the meanwhile I have asked rangi to enable https on the manual (was not there before).
- choice vs multiple in the added KohaManualLanguage sys pref
It's a choice indeed.
- help.pl removed from 00-strict.t
Re-added
- postfix slash the default URL creates a // in the URL. remove the '/' in the URL building in Koha::Manual? build smarter?
I do not understand what you suggest here.
kshell cd misc/translator for i in `ls po | cut -f1-2 -d'-' | sed -e "s#-opac##g" | sed -e "s#-pref.po##g" | sed -e "s#-staff##g" | sed -e "s#-marc##g" | sort -u`; do echo $i;perl translate install $i;done -- noisy! Though, I suspect correct. perhaps help po files need to be deleted too?
I do not think so, should be deleted on releasing (there are certainly other things to do in the release scripts). -- You are receiving this mail because: You are watching all bug changes.