[Bug 33901] New: Only one issue shown in Test prediction pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Bug ID: 33901 Summary: Only one issue shown in Test prediction pattern Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org I think this is similar to bug 32554, but in another page/context. When creating a numbering pattern, you have the option to test it before saving it. However, it doesn't show the number of issues you select in the test. To recreate: 1. Go to Serials > Manage numbering patterns 2. Click Edit next to one of the existing patterns (e.g. Number) 3. Enter information in the Test prediction pattern section - Frequency: choose one (e.g. 1/month) - First issue publication date: enter a date (e.g. 2023-06-01) - Subscription length: issues + enter a number of issues (e.g. 12) - Locale: leave empty - Begins with: enter a number in the X column, e.g. 42 4. Click Test pattern --> Only one issue is shown, no matter how many you enter in Subscription length. Having only one issue doesn't help at all to know if your numbering pattern will work correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32554 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC| |jonathan.druart+koha@gmail. | |com Status|NEW |ASSIGNED Depends on| |30718 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This was wrong: -$enddate = eval { output_pref( { str => $enddate, dateonly => 1, dateformat => 'iso' } ); }; +$enddate = dt_from_string($enddate)->ymd; Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 [Bug 30718] Use flatpickr's altInput option everywhere -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152084&action=edit Bug 33901: (bug 30718 follow-up) Predition pattern - don't set end date to today If the end date is not set we should not set it to today. On bug 30718 the following change was wrong: -$enddate = eval { output_pref( { str => $enddate, dateonly => 1, dateformat => 'iso' } ); }; +$enddate = dt_from_string($enddate)->ymd; output_pref returns undef if str is empty After the change we returned today's date. Test plan: 1. Go to Serials > Manage numbering patterns 2. Click Edit next to one of the existing patterns (e.g. Number) 3. Enter information in the Test prediction pattern section - Frequency: choose one (e.g. 1/month) - First issue publication date: enter a date (e.g. 2023-06-01) - Subscription length: issues + enter a number of issues (e.g. 12) - Locale: leave empty - Begins with: enter a number in the X column, e.g. 42 4. Click Test pattern => Without this patch only one issue is shown, no matter how many you enter in Subscription length => With this patch applied the end date is not set to today and the prediction pattern list is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152084|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 152105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152105&action=edit Bug 33901: (bug 30718 follow-up) Predition pattern - don't set end date to today If the end date is not set we should not set it to today. On bug 30718 the following change was wrong: -$enddate = eval { output_pref( { str => $enddate, dateonly => 1, dateformat => 'iso' } ); }; +$enddate = dt_from_string($enddate)->ymd; output_pref returns undef if str is empty After the change we returned today's date. Test plan: 1. Go to Serials > Manage numbering patterns 2. Click Edit next to one of the existing patterns (e.g. Number) 3. Enter information in the Test prediction pattern section - Frequency: choose one (e.g. 1/month) - First issue publication date: enter a date (e.g. 2023-06-01) - Subscription length: issues + enter a number of issues (e.g. 12) - Locale: leave empty - Begins with: enter a number in the X column, e.g. 42 4. Click Test pattern => Without this patch only one issue is shown, no matter how many you enter in Subscription length => With this patch applied the end date is not set to today and the prediction pattern list is correct Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Jonathan! It's much better now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I think this patch may also solve bug 32554 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152105|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152217&action=edit Bug 33901: (bug 30718 follow-up) Predition pattern - don't set end date to today If the end date is not set we should not set it to today. On bug 30718 the following change was wrong: -$enddate = eval { output_pref( { str => $enddate, dateonly => 1, dateformat => 'iso' } ); }; +$enddate = dt_from_string($enddate)->ymd; output_pref returns undef if str is empty After the change we returned today's date. Test plan: 1. Go to Serials > Manage numbering patterns 2. Click Edit next to one of the existing patterns (e.g. Number) 3. Enter information in the Test prediction pattern section - Frequency: choose one (e.g. 1/month) - First issue publication date: enter a date (e.g. 2023-06-01) - Subscription length: issues + enter a number of issues (e.g. 12) - Locale: leave empty - Begins with: enter a number in the X column, e.g. 42 4. Click Test pattern => Without this patch only one issue is shown, no matter how many you enter in Subscription length => With this patch applied the end date is not set to today and the prediction pattern list is correct Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Much better, thx Caroline for filing and Jonathan for the fix :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|Only one issue shown in |Only one issue shown when |Test prediction pattern |testing prediction pattern -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Sue <yach@morainevalley.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |yach@morainevalley.edu --- Comment #11 from Sue <yach@morainevalley.edu> --- Still experiencing only one issue showing when testing prediction patterns in 22.11.07. Similar to bug 32554 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to oldstable --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Sue from comment #11)
Still experiencing only one issue showing when testing prediction patterns in 22.11.07. Similar to bug 32554
This is to be expected: see the Versions released in at the top. The fix will be included in 22.11.08. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org