[Bug 10514] New: Add item link on acquisitions add item is too small
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Bug ID: 10514 Summary: Add item link on acquisitions add item is too small Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: wizzyrea@gmail.com I have had at least 3 libraries totally miss the "add" link when adding an item to an order in acquisitions, which I take as a sign that it should be made bigger. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 19274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19274&action=edit Bug 10514 - make the add item link more noticeable when adding items to orders it was so small. People were missing it all the time! To test: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19274|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19504&action=edit Bug 10514 - make the add item link more noticeable when adding items to orders it was so small. People were missing it all the time! To test: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 9539 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19531&action=edit screenshot Hi Liz, I totally agree that we need the links to stand out more, but I am not sold on the idea to make the font bigger. With the CSS in the top of the page it's also hard to change it back if you wanted to. Maybe we could use buttons? Another problem I spotted while looking at this bit of code: as it stands right now, those links are not translatable! It's a problem before and after your patch and can go onto another bug. But if you want to try - using a concatenated Javascript string with _() in the right place should fix it. But failing for wrong capitalization - sorry! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- I don't like buttons there, that's not the end of the page and it just feels weird to me. The CSS is in the staff global css file, so not sure what you're getting at? As for it not being translatable - that predates this patch. Maybe I'll fix it though. For now, I'll probably just fix the capitalisation. ;) Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19504|0 |1 is obsolete| | --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 19536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19536&action=edit Bug 10514 - make the add item link more noticeable when adding items to orders it was so small. People were missing it all the time! To test: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Follow up for translation and capitalisation. Probably deserves another sign off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You are right about the CSS - sorry! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19571&action=edit Bug 10514 [Alternate] Add item link on acquisitions add item is too small This alternate patch for Bug 10514 converts the "Add" and "Clear" links to the standard "submit/cancel" format inside a fieldset. This gives them a little more visual weight to solve the problem in a differnt way. Based on the changes made by Liz Rea and Jonathan Druart. Same test plan: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10576 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19536|0 |1 is obsolete| | Attachment #19571|0 |1 is obsolete| | --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 19583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19583&action=edit Bug 10514 [Alternate] Add item link on acquisitions add item is too small This alternate patch for Bug 10514 converts the "Add" and "Clear" links to the standard "submit/cancel" format inside a fieldset. This gives them a little more visual weight to solve the problem in a differnt way. Based on the changes made by Liz Rea and Jonathan Druart. Same test plan: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. Signed-off-by: Liz Rea <liz@catalyst.net.nz> I still feel weird about the button, but as two people have said they'd rather have the button, I'm alright with it I guess. Really what I want is people to notice it's there and click it at the appropriate time. I hope this will help that issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19583|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19585&action=edit [PASSED QA] Bug 10514 [Alternate] Add item link on acquisitions add item is too small This alternate patch for Bug 10514 converts the "Add" and "Clear" links to the standard "submit/cancel" format inside a fieldset. This gives them a little more visual weight to solve the problem in a differnt way. Based on the changes made by Liz Rea and Jonathan Druart. Same test plan: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. Signed-off-by: Liz Rea <liz@catalyst.net.nz> I still feel weird about the button, but as two people have said they'd rather have the button, I'm alright with it I guess. Really what I want is people to notice it's there and click it at the appropriate time. I hope this will help that issue. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Leaves the translation problems, but that needs more work and is out of the scope of this bug. Tested Add and Update functionality works correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19586&action=edit screenshot - display using alternate patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have attached 2 screenshots to compare the results of both patches. I personally like the second a bit better, because it fits how we do things in other places. There was also a suggestion to add some additional text to the form on IRC: (23:28:47) rangi: id like some text (23:28:51) rangi: right below Item (23:29:15) rangi: (Fill in the following form and click add, to add 1 item to your order, do this as many times as needed) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, everybody! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks everyone involved! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #16 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org