[Bug 10411] New: Add cache control headers to static resources in the apache config
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Bug ID: 10411 Summary: Add cache control headers to static resources in the apache config Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: robin@catalyst.net.nz CC: robin@catalyst.net.nz Currently, the static resources aren't explicitly cached. In the case of firefox, this causes a request every time for every image, that usually results in a 304 Not Modified response. This isn't a good use of apache's time, also may make the page appear to render a bit slower. The patch for this will put a 12 hour cache timeout on the images, javascript, and CSS files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 18653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18653&action=edit Bug 10411 - add cache control headers for static resources This adds caching directives to the static resources so that the browser doesn't ask about them all the time. By default, Debian apache doesn't have the required module (mod_expires) enabled, and so this patch will have no effect. In order to enable this function, run: a2enmod expires and restart apache. Test Plan: * Using firebug or equivalent, load a page. * Note that none of the images, css, or js files have a Cache-Control or Expires header set. * Add this patch, redeploy the package with it (or overwrite the apache-share.conf file) enable the 'expires' module, restart apache. * Force-reload the page * Note that the images, css, js now have Cache-Control and Expires set for 12 hours into the future. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |robin@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18653|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 19088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19088&action=edit Bug 10411: add cache control headers for static resources (Debian package) This adds caching directives to the static resources so that the browser doesn't ask about them all the time. By default, Debian apache doesn't have the required module (mod_expires) enabled, and so this patch will have no effect. In order to enable this function, run: a2enmod expires and restart apache. Test Plan: * Using firebug or equivalent, load a page. * Note that none of the images, css, or js files have a Cache-Control or Expires header set. * Add this patch, redeploy the package with it (or overwrite the apache-share.conf file) enable the 'expires' module, restart apache. * Force-reload the page * Note that the images, css, js now have Cache-Control and Expires set for 12 hours into the future. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Looks good to me, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19088|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19750&action=edit Bug 10411: add cache control headers for static resources (Debian package) This adds caching directives to the static resources so that the browser doesn't ask about them all the time. By default, Debian apache doesn't have the required module (mod_expires) enabled, and so this patch will have no effect. In order to enable this function, run: a2enmod expires and restart apache. Test Plan: * Using firebug or equivalent, load a page. * Note that none of the images, css, or js files have a Cache-Control or Expires header set. * Add this patch, redeploy the package with it (or overwrite the apache-share.conf file) enable the 'expires' module, restart apache. * Force-reload the page * Note that the images, css, js now have Cache-Control and Expires set for 12 hours into the future. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Robin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #8 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org