[Bug 8490] New: Error when adding label layout under plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 Priority: P5 - low Change sponsored?: --- Bug ID: 8490 Assignee: cnighswonger@foundations.edu Summary: Error when adding label layout under plack Severity: normal Classification: Unclassified OS: All Reporter: 5p4m@gmx.de Hardware: All Status: NEW Version: master Component: Label printing Product: Koha Error message "Can't bless non-reference value at /home/pi/koha/C4/Creators/Layout.pm line 111." when trying to add a label layout while using plack. To reproduce: go to Tools> Label creator> Layouts> New layout; edit layout name and press 'Save. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cnighswonger@foundations.ed | |u, | |paul.poulain@biblibre.com Assignee|cnighswonger@foundations.ed |paul.poulain@biblibre.com |u | --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> --- Chris_n => THIS IS FOR YOU ! I think I've understood why the problem occurs: the $layout_id variable is set to 5001 on my setup. And 5001 is the Unix port where I run Plack. WTH is this value stored in this variable ? Because of my $layout_id = $cgi->param('layout_id') || $cgi->param('element_id') || $ARGV[1] || ''; in label-edit-layout.pl Removing $ARGV[1] solves the problem Why is the ARGV[1] here, I have no idea. Is this script sometimes run from commandline ? I don't think so. This ||ARGV[1] has been added by chris_n in the commit : 12663796ca87cf87f89fd1ba1f2949ec33b76b85 Auteur: Chris Nighswonger <cnighswonger@foundations.edu> 2009-07-20 19:24:49 [8/40] Adding new layout management page This moves the layouts off of the labels tool start page to bring it into conformity with the other parts of this tool. assigning bug to me, and adding chris_n in cc: -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13197&action=edit Bug 8490 fixing Plack error This patch fixes "Error message "Can't bless non-reference value at /home/pi/koha/C4/Creators/Layout.pm line 111." when trying to add a label layout while using plack." The $layout_id variable is set to 5001 on my setup. And 5001 is the Unix port where I run Plack. WTH is this value stored in this variable ? Because of my $layout_id = $cgi->param('layout_id') || $cgi->param('element_id') || $ARGV[1] || ''; in label-edit-layout.pl Removing $ARGV[1] solves the problem Also removing $ARG[0] because I also don't think it's useful -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Severity|normal |blocker --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Upgrading severity because there's no workaround, it's a blocker to use Plack -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #2)
Removing $ARGV[1] solves the problem Also removing $ARG[0] because I also don't think it's useful
You're right about the cli args, Paul. In this script they were there for my debugging very early on and should have been removed. No functionality should be broken by removing them. IIRC this may not be true for all of the label/patron card related scripts, however. Ie. those that generate the PDF, CSV, etc. files from batches, etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13197|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13208&action=edit Bug 8490: fix Plack error when creating label layout This patch fixes "Error message "Can't bless non-reference value at /home/pi/koha/C4/Creators/Layout.pm line 111." when trying to add a label layout while using plack." The $layout_id variable is set to 5001 on my setup. And 5001 is the Unix port where I run Plack. WTH is this value stored in this variable ? Because of
my $layout_id = $cgi->param('layout_id') || $cgi->param('element_id') || $ARGV[1] || ''; in label-edit-layout.pl
Removing $ARGV[1] solves the problem Also removing $ARG[0] because I also don't think it's useful Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed off after confirming with Chris Nighswonger that these scripts were not intended to be run from the command line. Works as promised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: No regression introduced with this patch. So I mark it as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8490 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org