[Bug 8633] New: Translate script hardcoded to prog template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Priority: P5 - low Change sponsored?: --- Bug ID: 8633 CC: frederic@tamil.fr Assignee: koha-bugs@lists.koha-community.org Summary: Translate script hardcoded to prog template Severity: normal Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: I18N/L10N Product: Koha misc/translator/translate is hardcoded to translate only prog, when in fact it should be translating any themes included in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Frédéric Demians <frederic@tamil.fr> ---
From my perspective, the Koha theme concept is deprecated. It has been proved by experience that specific theme is un-maintenable. To be confirmed by others.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #1)
From my perspective, the Koha theme concept is deprecated. It has been proved by experience that specific theme is un-maintenable. To be confirmed by others.
I disagree, it has been proven the way people tried to do it in the past was unmaintanable. The new mobile theme patches are much much more maintainable, as they only contain the 2 or 3 actually changed files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> ---
misc/translator/translate is hardcoded to translate only prog, when in fact it should be translating any themes included in Koha.
For each template, we would have to create 2 .po files, one per interface, OPAC or professional. Does it make sense to generate .po files for intranet template other than 'prog'? Why would we want to include a second template for intranet interface? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #3)
misc/translator/translate is hardcoded to translate only prog, when in fact it should be translating any themes included in Koha.
For each template, we would have to create 2 .po files, one per interface, OPAC or professional. Does it make sense to generate .po files for intranet template other than 'prog'? Why would we want to include a second template for intranet interface?
I can't really think of any reason we would want to, to be honest. The change I made to translate the ccsr theme was to add: + ccsr => { + dir => $context->config('opachtdocs') . '/ccsr', + suffix => '-i-opac-t-ccsr-v-3006000.po', + }, in the $self->{interface} definition in new. I am not sure if that is the best way, which is why I defer to you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Assignee|koha-bugs@lists.koha-commun |frederic@tamil.fr |ity.org | --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 12342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12342&action=edit Bug 8633 Manage OPAC alternate templates Modify /misc/translator/translate script in order to manage properly alternate OPAC templates. To test it with new 'ccsr' template: - Create the .po file: ./translate create fr-FR Result: existing .po files are not modified. A new fr-FR-opac-ccsr.po file is available. - Install all templates : ./translate install fr-FR Result: A new koha-tmpl/opac-tmpl/ccsr/fr-FR directory contains translated templates. - Update .po files: ./translate update fr-FR Result: fr-FR .po files are update, include fr-FR-opac-ccsr.po -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12342|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12556&action=edit Bug 8633 Manage OPAC alternate templates Modify /misc/translator/translate script in order to manage properly alternate OPAC templates. To test it with new 'ccsr' template: - Create the .po file: ./translate create fr-FR Result: existing .po files are not modified. A new fr-FR-opac-ccsr.po file is available. - Install all templates : ./translate install fr-FR Result: A new koha-tmpl/opac-tmpl/ccsr/fr-FR directory contains translated templates. - Update .po files: ./translate update fr-FR Result: fr-FR .po files are update, include fr-FR-opac-ccsr.po Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> ---
To test it with new 'ccsr' template:
Result: fr-FR .po files are update, include fr-FR-opac-ccsr.po
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
confirmed working by me, passing QA... mason@xen1:~/g/head$ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 6c18204) * fd5bae3 Bug 8633 Manage OPAC alternate templates misc/translator/LangInstaller.pm * misc/translator/LangInstaller.pm OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: just a question before pushing = why do you have kept the -v-3006000 in prog template, and removed it from ccsr ? could be a little bit confusing, don't you think ? I don't know why we need keep the -v-3006000 in the translation name, and maybe removing it would require a much larger patch, to rename all existing translations, just asking to be sure we haven't missed anything ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 --- Comment #9 from Frédéric Demians <frederic@tamil.fr> ---
QA comment: just a question before pushing = why do you have kept the -v-3006000 in prog template, and removed it from ccsr ? could be a little bit confusing, don't you think ? I don't know why we need keep the -v-3006000 in the translation name, and maybe removing it would require a much larger patch, to rename all existing translations, just asking to be sure we haven't missed anything !
The -v-3006000 part of the name is useless. We already don't have it for preferences .po files. I avoided to add it to the new ccsr .po files. We could easily suppress this in opac/staff files. But this has to be done also on Koha Pootle translation server. I think we should plan this with the extraction of all .po files from code Git repository. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #9)
The -v-3006000 part of the name is useless.
OK, removing it will be for another patch. patch pushed ! (no need to push this to 3.8, there's no cssr theme) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9018 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org