[Bug 34400] New: Inconsistencies in OAI sets page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Bug ID: 34400 Summary: Inconsistencies in OAI sets page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the OAI sets page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'OAI sets configuration' to 'OAI sets' - Change 'Add a new OAI set' to 'New OAI set' - Add a level for when modifying an existing set "Modify OAI set 'code'" - Change 'OAI set mappings' to "Mappings for set 'name' (code)" Breadcrumb - Change 'OAI sets configuration' to 'OAI sets' - Change 'Add a new OAI set' to 'New OAI set' - Change "Edit OAI set 'code'" to "Modify OAI set 'code'" - Change 'OAI set mappings' to "Mappings for set 'name' (code)" Page header - Change 'Add a new OAI set' to 'New OAI set' - Change "Edit OAI set 'code'" to "Modify OAI set 'code' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155035&action=edit Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 155035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155035 Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header Review of attachment 155035: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=34400&attachment=155035) ----------------------------------------------------------------- Overall, I think it's looking pretty good, but I did note a new inconsistency introduced by this patch. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt @@ +29,4 @@
[% IF ( op_new || op_mod ) %] [% WRAPPER breadcrumb_item %] + <a href="/cgi-bin/koha/admin/oai_sets.pl">OAI sets</a>
This change makes the breadcrumb inconsistent with oai_set_mappings.tt though. @@ +44,5 @@
[% END %]
[% ELSE %] [% WRAPPER breadcrumb_item bc_active= 1 %] + <span>OAI sets</span>
This change makes the breadcrumb inconsistent with oai_set_mappings.tt though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155035|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155261&action=edit Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 emily-rose.francoeur@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 emily-rose.francoeur@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155261|0 |1 is obsolete| | --- Comment #4 from emily-rose.francoeur@inLibro.com --- Created attachment 155495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155495&action=edit Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155495|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155755&action=edit Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the style of the OIA sets administration screen, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The patch also corrects the structure of the form on the OAI set mappings page so that the submit button is outside the "page-section" area. To test, apply the patch and go to Administration -> OAI sets. Test each variation of the page: - Main page - New OAI set - Edit OAI set - OAI set mappings Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Like others, not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org