[Bug 34394] New: Inconsistencies in MARC Bibliographic framework test page title and breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Bug ID: 34394 Summary: Inconsistencies in MARC Bibliographic framework test page title and breadcrumbs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the MARC Bibliographic framework test page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change the level to 'MARC bibliographic framework test' (I would remove any mention of success or errors here) Breadcrumb - Change the level to 'MARC bibliographic framework test' (I would remove any mention of success or errors here) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154815&action=edit Bug 34394: Fix inconsistencies in MARC Bibliographic framework test page title and breadcrumbs This patch makes some changes to the MARC bibliographic framework test page so that breadcrumbs, page title, and page heading are consistent with each other. The patch also creates standard message and alert dialogs to show the status of the check. This is more consistent than having the message only at the bottom of the table. The patch also changes the term "itemnum" to "itemnumber." To test, apply the patch and go to Admnistration -> MARC bibliographic framework test. - The page title, breadcrumb navigation, and page heading should match: "MARC bibliographic framework test." - If your system has no errors, there should be a message-style dialog at the top of the page saying "Configuration okay." - Create an error in your MARC configuration: - Go to Administration -> MARC frameworks -> MARC structure - Locate the 952 tag and click Actions -> View subfields - Edit subfield 9 and set the "Managed in tab" dropdown to something other than "ignore" - Return to the framework test page. There should be an alert-style dialog at the top of the page, "Configuration errors found" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Owen! It's much better now. I wonder if we should remove the "TOTAL" line of the table when there is an error? https://snipboard.io/VXsJ6I.jpg And also use the singular/plural thing... Not sure what it is called, but the thing that allows to have one string for 1 and one string for more than 1, like "you have 1 error" (singular error) vs "you have 2 errors" (plural errors)? I'm still singing off because I think it's OK as it is. But I can sign off any follow ups. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154815|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 154887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154887&action=edit Bug 34394: Fix inconsistencies in MARC Bibliographic framework test page title and breadcrumbs This patch makes some changes to the MARC bibliographic framework test page so that breadcrumbs, page title, and page heading are consistent with each other. The patch also creates standard message and alert dialogs to show the status of the check. This is more consistent than having the message only at the bottom of the table. The patch also changes the term "itemnum" to "itemnumber." To test, apply the patch and go to Admnistration -> MARC bibliographic framework test. - The page title, breadcrumb navigation, and page heading should match: "MARC bibliographic framework test." - If your system has no errors, there should be a message-style dialog at the top of the page saying "Configuration okay." - Create an error in your MARC configuration: - Go to Administration -> MARC frameworks -> MARC structure - Locate the 952 tag and click Actions -> View subfields - Edit subfield 9 and set the "Managed in tab" dropdown to something other than "ignore" - Return to the framework test page. There should be an alert-style dialog at the top of the page, "Configuration errors found" Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34635 [Bug 34635] Use pluralization for MARC Bibliographic framework test error message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154887|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155059&action=edit Bug 34394: Fix inconsistencies in MARC Bibliographic framework test page title and breadcrumbs This patch makes some changes to the MARC bibliographic framework test page so that breadcrumbs, page title, and page heading are consistent with each other. The patch also creates standard message and alert dialogs to show the status of the check. This is more consistent than having the message only at the bottom of the table. The patch also changes the term "itemnum" to "itemnumber." To test, apply the patch and go to Admnistration -> MARC bibliographic framework test. - The page title, breadcrumb navigation, and page heading should match: "MARC bibliographic framework test." - If your system has no errors, there should be a message-style dialog at the top of the page saying "Configuration okay." - Create an error in your MARC configuration: - Go to Administration -> MARC frameworks -> MARC structure - Locate the 952 tag and click Actions -> View subfields - Edit subfield 9 and set the "Managed in tab" dropdown to something other than "ignore" - Return to the framework test page. There should be an alert-style dialog at the top of the page, "Configuration errors found" Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Like others, not backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34394 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org