[Bug 11934] New: Replace given by if-else in Circulation_issuingrules.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 Bug ID: 11934 Summary: Replace given by if-else in Circulation_issuingrules.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: nicolas.legrand@bulac.fr QA Contact: gmcharlt@gmail.com given statement are to be replaced by if else statements -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 --- Comment #1 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 26231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26231&action=edit Bug 11934 - Replace given by if-else statments -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26231|0 |1 is obsolete| | --- Comment #2 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 26238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26238&action=edit Bug 11934 - Replace given by if-else statments -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26238|0 |1 is obsolete| | --- Comment #3 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 26242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26242&action=edit Bug 11934 - Replace given by if-else statments -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 26248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26248&action=edit [SIGNED OFF] Bug 11934 - Replace given by if-else statments Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26242|0 |1 is obsolete| | CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 26242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26242 Bug 11934 - Replace given by if-else statments Great work, cleans up code and maintains correct function. Signed off, go forth and QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer@bsz-bw.de Assignee|chris@bigballofwax.co.nz |nicolas.legrand@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26272&action=edit [PASSED QA] Bug 11934 - Replace given by if-else statments Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> replaces given-when with if-elsif-else constructs. Tests still pass and code looks good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up to tidy up whitespace. This appears to be your first commit pushed to Koha master. Congratulations, Nicolas! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 --- Comment #8 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Thank you ^^ and thanks to Katrin and Martin who very kindly proposed it to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 Congratulations Nicolas, you're in stable branch also ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x, will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org