https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194270&action=edit Bug 4858: (QA follow-up) Fix high-priority issues - Remove duplicate 'use Scalar::Util' import introduced by this patch; the import already existed at line 26 of Koha/Patron.pm. - Pass notice_code as the note field on the add_debit call in add_print_notice_charge_if_needed. Previously the notice_code parameter was accepted but silently dropped, meaning all print notice charges looked identical in the account with no way to identify which letter triggered the charge. - Add print transport column to the OPAC messaging preferences table (opac-messaging.tt). The original patch added a print notice charging warning in the OPAC that told patrons to "uncheck print notice options" but never actually gave them a column to do so. This adds the print column to the OPAC table header and body rows (mirroring the staff messaging-preference-form.inc implementation), and adds a pmp_print JS click handler for the toggle_digest function, so patrons can opt out of print notices themselves. - Align PRINT_NOTICE debit type default_amount between fresh install and upgrade: account_debit_types.yml correctly set this to NULL (charge amount is per patron category, not a global default) but the atomicupdate was inserting 0.50. Changed atomicupdate to NULL. Sponsored-by: OpenFifth <https://openfifth.co.uk\> Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.