https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194271&action=edit Bug 4858: (QA follow-up) Miscellaneous fixes - Add print_notice_charge to Koha::Patron::Category to_api_mapping. - Remove over-defensive branchcode and letter_code regex validation in gather_print_notices.pl::apply_print_notice_charge; the data is internal (from GetPrintMessages DB query) and the regex could silently skip charges for libraries with spaces or special characters in their branchcode. - Fix cronlogaction indentation inside apply_print_notice_charge. - Move test file from t/db_dependent/Koha/Account/PrintNoticeCharges.t to t/db_dependent/Koha/Patron/PrintNoticeCharge.t to match the class being tested (Koha::Patron, not Koha::Account::PrintNoticeCharges). - Add missing trailing newline to t/db_dependent/PrintNoticeCharging_EndToEnd.t. Sponsored-by: OpenFifth <https://openfifth.co.uk\> Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.