[Bug 10922] New: Display if prices are tax exc. or inc. when creating a new order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Bug ID: 10922 Summary: Display if prices are tax exc. or inc. when creating a new order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org When creating a new order, there must be a way to know if the list price, replacement price, budgeted price, and actual cost are with or without tax. Further improvement : if list price is tax exc., currently, neworderempty does not display the prices tax inc.. They are only displayed in basket page. This could be improved. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 21273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21273&action=edit [PATCH] Bug 10922: Display if prices are tax exc. or inc. when creating a new order This patch adds "(tax inc.)" or "(tax exc.)" after the "Vendor price", "Replacement cost", "Budgeted cost" and "Actual cost" when entering a new order. Actual cost must probably not be displayed here, but it will be the subject of an other patch. To test : - create 2 vendors, with differents values for "List prices includes tax" and "Invoiced prices does includes tax" options - create baskets for these 2 vendors - create an order in each basket, and look at the "tax. inc." and "tax exc" mention. It should be consistent with the options for each vendor - look at an order adding "&close=1" to the normal URL of the order. You must see the order without ability to edit it, but with the same mentions "tax inc." and "tax exc." M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Note : currently, the "&close=1" is not used by Koha, but it must be fixed later. See Bug 10921 Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-24 last check this| | --- Comment #3 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-24 00:00:00 |2013-10-25 last check this| | --- Comment #4 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #5 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hi Mathieu, I'm not sure that this choice (including or excl) have to be made in the order. In the actual functioning, it's in the vendor page that you can choose if list price or actual cost are with or without tax. It can be extended to remplacement price or budgeted price. ARe tou sure that a vendor have different politics of prices (including tax or not) ? Sonia -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #6 from mathieu saby <mathsabypro@gmail.com> --- (In reply to Koha Team Lyon 3 from comment #5)
Hi Mathieu, I'm not sure that this choice (including or excl) have to be made in the order. In the actual functioning, it's in the vendor page that you can choose if list price or actual cost are with or without tax. It can be extended to remplacement price or budgeted price. ARe tou sure that a vendor have different politics of prices (including tax or not) ? Sonia
This patch does not add a new choice on order page, it only displays the information (as defined on the vendor page, like before). I think it can be useful for librarians who are only creating orders (so they don't need to check the vendor's page). Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Ok Mathieu, that's fine so -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by isabelle.beroud@univ-lyon3.fr <isabelle.beroud@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21273|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 24110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24110&action=edit Bug 10922: Display if prices are tax exc. or inc. when creating a new order This patch adds "(tax inc.)" or "(tax exc.)" after the "Vendor price", "Replacement cost", "Budgeted cost" and "Actual cost" when entering a new order. Actual cost must probably not be displayed here, but it will be the subject of an other patch. To test : - create 2 vendors, with differents values for "List prices includes tax" and "Invoiced prices does includes tax" options - create baskets for these 2 vendors - create an order in each basket, and look at the "tax. inc." and "tax exc" mention. It should be consistent with the options for each vendor - look at an order adding "&close=1" to the normal URL of the order. You must see the order without ability to edit it, but with the same mentions "tax inc." and "tax exc." Signed-off-by: isabelle.beroud@univ-lyon3.fr <isabelle.beroud@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #10 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I made test : I created 2 vendors : - one with List prices and Invoiced prices : option tax includes - One another with List prices and Invoiced prices : option tax excludes For these 2 vendors, I created baskets and an order, in each basket. The "tax. inc." and "tax exc" mention were consistent with the options for each vendor : it’s ok. Then adding "&close=1" to the normal URL of the order, there are the same mentions "tax inc." and "tax exc." Isabelle Beroud -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually, this is quite interesting and confusing to me. Libraries here have to pay the tax, so I would expect the budgeted cost to include a calculated tax, if list prices are tax exclusive. Shouldn't the tax rate influence the prices in some way? I couldn't see that whatever combinatoin I tried. Budgeted cost and replacement cost being the same tax setting as the list price seems currently correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24110|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24555&action=edit [PASSED QA] Bug 10922: Display if prices are tax exc. or inc. when creating a new order This patch adds "(tax inc.)" or "(tax exc.)" after the "Vendor price", "Replacement cost", "Budgeted cost" and "Actual cost" when entering a new order. Actual cost must probably not be displayed here, but it will be the subject of an other patch. To test : - create 2 vendors, with differents values for "List prices includes tax" and "Invoiced prices does includes tax" options - create baskets for these 2 vendors - create an order in each basket, and look at the "tax. inc." and "tax exc" mention. It should be consistent with the options for each vendor - look at an order adding "&close=1" to the normal URL of the order. You must see the order without ability to edit it, but with the same mentions "tax inc." and "tax exc." Signed-off-by: Isabelle Beroud <isabelle.beroud@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. I have some doubts about the calculations done here, but the display changes are correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 --- Comment #13 from mathieu saby <mathsabypro@gmail.com> --- (In reply to Katrin Fischer from comment #11)
Actually, this is quite interesting and confusing to me.
Libraries here have to pay the tax, so I would expect the budgeted cost to include a calculated tax, if list prices are tax exclusive. Shouldn't the tax rate influence the prices in some way? I couldn't see that whatever combinatoin I tried.
Budgeted cost and replacement cost being the same tax setting as the list price seems currently correct.
This bug is not supposed to fix anything, just to make clearer for the user the current behavior of Koha But yes, there is a LOT of issues regarding taxes. Lyon 3 university is planning some improvements. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org