http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 24033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24033&action=edit message not showing This patch is awesome and works for everything - but not if the item is on hold. See attached image. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Nicole C. Engard from comment #2)

Created attachment 24033 [details] message not showing

This patch is awesome and works for everything - but not if the item is on hold. See attached image.

Nicole, that was intentional. If you look at the OPAC, you should see the same behaviour, because you shouldn't be able to renew an item that has been placed on hold. I'll move this back to "Needs Signoff", but happy to have a discussion about this, if folks want. I don't think there are cases where you can renew a book that is on hold for someone else, but perhaps I'm wrong? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23982|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 24093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24093&action=edit [SIGNED-OFF] Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record This patch adds the renewal count to the 'Check out' and "Details' tabs of the patron record. This information already exists in the OPAC view of the patron record. Since librarians might be serving patrons in person who want to know this information without looking it up online, it makes sense to show it in the staff client. There may also be times where librarians want to see how many renewals a patron has left, how many they've used already, etc. when making other decisions. _TEST PLAN_ Before applying: 1) Go to "Check out" with a patron that has some check outs before today 2) Add some check outs for today *Ensure that all issues are for items that can be renewed* 3) Note that the Renew column just says '0' followed by a check box 4) Check the 'Detail' tab. It should say the same. Apply the patch. 5) View the "Details" and "Check out" tabs again 6) Note that the renewal count now appears in the form resembling: 5 of 5 renewals remaining Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- David, Don't you think it is useless to display the information if not renewal is possible? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24114&action=edit Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record This patch adds the renewal count to the 'Check out' and "Details' tabs of the patron record. This information already exists in the OPAC view of the patron record. Since librarians might be serving patrons in person who want to know this information without looking it up online, it makes sense to show it in the staff client. There may also be times where librarians want to see how many renewals a patron has left, how many they've used already, etc. when making other decisions. _TEST PLAN_ Before applying: 1) Go to "Check out" with a patron that has some check outs before today 2) Add some check outs for today *Ensure that all issues are for items that can be renewed* 3) Note that the Renew column just says '0' followed by a check box 4) Check the 'Detail' tab. It should say the same. Apply the patch. 5) View the "Details" and "Check out" tabs again 6) Note that the renewal count now appears in the form resembling: 5 of 5 renewals remaining Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #6)

David, Don't you think it is useless to display the information if not renewal is possible?

Honestly, I don't have a strong opinion either way. I was just trying to stay consistent with current behaviour. I'm more than happy for Nicole to open a bug to change current behaviour in the OPAC (and the staff client as well presuming this gets in). -- You are receiving this mail because: You are watching all bug changes.