[Bug 28611] New: Incorrect Select2 width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Bug ID: 28611 Summary: Incorrect Select2 width Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Cataloging Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The width picked by Select2 is not correct, the longest option's size is used but: * it is sometimes split on two lines * the close button hides the end of the value https://snipboard.io/v4P7HN.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122276&action=edit Bug 28611: Fix width to 50% for additem form elements This patch suggests to set the width of select and input to 50% -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- With this patch applied: https://snipboard.io/rME6z3.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122276|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122390&action=edit Bug 28611: Fix width to 50% for additem form elements This patch suggests to set the width of select and input to 50% Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122390|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 122591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122591&action=edit Bug 28611: Fix width to 50% for additem form elements This patch suggests to set the width of select and input to 50% Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122591|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 122592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122592&action=edit Bug 28611: Fix width to 50% for additem form elements This patch suggests to set the width of select and input to 50% Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We know this is not the perfect solution, but until Select2 works better, I think this will be an improvement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.02 released in| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- It is a big visual change on items editor. I propose not to impact older versions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I understand the argument, but the visual was already changed by the newer version of select2 that made the input fields too short in many cases. I have seen library pull downs only showing like 3 letters of the branch names :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123590&action=edit Screenshot of item form pull downs in 20.11 (In reply to Katrin Fischer from comment #10)
I understand the argument, but the visual was already changed by the newer version of select2 that made the input fields too short in many cases. I have seen library pull downs only showing like 3 letters of the branch names :(
To explain a bit more, it means that currently you can't figure out the library actually selected, if you have some starting with the same letters. Also the X is too close to text, so I often have it happen that when I want to open the pull down, I actually empty the field. The screenshot shows the problematic classification source, home branch and holding branch selects on current 20.11.6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oh crap, a real ergonomic bug then. I backport. The backport on 20.11 actually fails because there is on select tag the attribute size="1". This has been removed in 21.05.x by Bug 28066. Should we keep it or remove it ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #12)
Oh crap, a real ergonomic bug then. I backport.
The backport on 20.11 actually fails because there is on select tag the attribute size="1". This has been removed in 21.05.x by Bug 28066.
Should we keep it or remove it ?
I believe removing it would be ok, but leaving it in probably won't cause issues right away either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #13)
(In reply to Fridolin Somers from comment #12)
Oh crap, a real ergonomic bug then. I backport.
The backport on 20.11 actually fails because there is on select tag the attribute size="1". This has been removed in 21.05.x by Bug 28066.
Should we keep it or remove it ?
I believe removing it would be ok, but leaving it in probably won't cause issues right away either.
Ok I choose to keep it. Thanks for your help ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.09 released in| | --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #10)
I understand the argument, but the visual was already changed by the newer version of select2 that made the input fields too short in many cases. I have seen library pull downs only showing like 3 letters of the branch names :(
I just saw this for the first time today and it's driving me crazy... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #17)
(In reply to Katrin Fischer from comment #10)
I understand the argument, but the visual was already changed by the newer version of select2 that made the input fields too short in many cases. I have seen library pull downs only showing like 3 letters of the branch names :(
I just saw this for the first time today and it's driving me crazy...
We set them to a wide width by default here, still waiting for aproper fix in the library I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 [Bug 35245] Incorrect select2 with in authorities cataloging -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org