[Bug 27325] New: Fix singular/plural forms on the OPAC dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Bug ID: 27325 Summary: Fix singular/plural forms on the OPAC dashboard Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 26123 At the moment the dashboard panel on the OPAC start page uses "checkout(s)", "overdue(s)", "hold(s)" etc. We have the tools now to deal with these in a nicer way, showing "1 hold" and "2 holds" and deal with these nicely in translations as well. For documentation see: https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_con... For an example see the result list on the staff side: https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tm... [% tnx('{count} item', '{count} items', SEARCH_RESULT.items_count, {count = SEARCH_RESULT.items_count}) | html %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Why not use something like the following instead? Checkouts: [% checkouts.count %] Overdues: [% overdues.count %] Holds: [% holds.count %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We could, but are we sure that this is nice in every language? I think using the singular/plural feature in such a prominent place would make sense and look good :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #2)
We could, but are we sure that this is nice in every language? I think using the singular/plural feature in such a prominent place would make sense and look good :)
I disagree about the singular/plural feature but that's OK. As for appropriateness for every language, I think avoiding singular/plural is more likely to be better for every language. I like the advice at https://developer.atlassian.com/server/framework/atlassian-sdk/pluralising-i... Considering that Atlassian has about 10 million active users of its products internationally in 190+ countries (https://www.atlassian.com/customers), I think it would be wise to listen to their advice. But that's just my 2 cents and I know I'm in the minority in this view. I figured I'd just reiterate it anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 114899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114899&action=edit Bug 27325: Fix singular/plural forms on the OPAC dashboard This patch adds handling of plurals to the display of counts on the logged-in user's dashboard: checkouts, overdues, etc. To test, apply the patch and log in to the OPAC. - Go to the OPAC main page and check the user dashboard area. - Confirm that the correct numbers and plural forms are shown for checkouts, overdues, holds pending, holds waiting, and messages. - Test each of those categories with counts of 0, 1, and more than one to confirm that the plural forms are correct. - Test with various counts of each type of message: OPAC notes as defined when editing a patron record and notes added via the checkout page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- This works good and it looks good. I think this is much cleaner looking than the with the (s). The plural and singular forms all work well for checkouts, overdues, holds pending, holds waiting, and messages. The template is missing some filters though: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL filters missing_filter at line 225 ( [% tn('checkout', 'checkouts', checkouts ) %]) missing_filter at line 233 ( [% tn('overdue', 'overdues', overdues ) %]) missing_filter at line 241 ( [% tn('hold pending', 'holds pending', holds_pending ) %]) missing_filter at line 249 ( [% tn('hold waiting', 'holds waiting', holds_waiting ) %]) missing_filter at line 266 ( [% tn('message', 'messages', patron_messages.count + 1 ) %]) missing_filter at line 273 ( [% tn('message', 'messages', patron_messages.count ) %]) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114899|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115015&action=edit Bug 27325: Fix singular/plural forms on the OPAC dashboard This patch adds handling of plurals to the display of counts on the logged-in user's dashboard: checkouts, overdues, etc. To test, apply the patch and log in to the OPAC. - Go to the OPAC main page and check the user dashboard area. - Confirm that the correct numbers and plural forms are shown for checkouts, overdues, holds pending, holds waiting, and messages. - Test each of those categories with counts of 0, 1, and more than one to confirm that the plural forms are correct. - Test with various counts of each type of message: OPAC notes as defined when editing a patron record and notes added via the checkout page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115015|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 115037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115037&action=edit Bug 27325: Fix singular/plural forms on the OPAC dashboard This patch adds handling of plurals to the display of counts on the logged-in user's dashboard: checkouts, overdues, etc. To test, apply the patch and log in to the OPAC. - Go to the OPAC main page and check the user dashboard area. - Confirm that the correct numbers and plural forms are shown for checkouts, overdues, holds pending, holds waiting, and messages. - Test each of those categories with counts of 0, 1, and more than one to confirm that the plural forms are correct. - Test with various counts of each type of message: OPAC notes as defined when editing a patron record and notes added via the checkout page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115037|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115102&action=edit Bug 27325: Fix singular/plural forms on the OPAC dashboard This patch adds handling of plurals to the display of counts on the logged-in user's dashboard: checkouts, overdues, etc. To test, apply the patch and log in to the OPAC. - Go to the OPAC main page and check the user dashboard area. - Confirm that the correct numbers and plural forms are shown for checkouts, overdues, holds pending, holds waiting, and messages. - Test each of those categories with counts of 0, 1, and more than one to confirm that the plural forms are correct. - Test with various counts of each type of message: OPAC notes as defined when editing a patron record and notes added via the checkout page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |This updates the messages released in| |used for the patron | |dashboard on the OPAC start | |page to use the proper | |singular and plural forms: | |1 hold, 2 holds, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)|This updates the messages |21.05.00 released in|used for the patron | |dashboard on the OPAC start | |page to use the proper | |singular and plural forms: | |1 hold, 2 holds, etc. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Bug 27325 depends on bug 26123, which changed state. Bug 26123 Summary: Show info about existing OPAC note/Patron message on patron's dashboard https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26123 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Bug 27325 depends on bug 26123, which changed state. Bug 26123 Summary: Show info about existing OPAC note/Patron message on patron's dashboard https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org