[Bug 42519] New: Terminology: branch should be library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 Bug ID: 42519 Summary: Terminology: branch should be library Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: Academy Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Found while translating main: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt:578 Your self-renewal can't be processed at this time. Please visit your local branch to complete your renewal. Also: for installations with only one library this might sound little odd, maybe just: visit your library? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42721 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 Samuel Sowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam.sowanick@corvallisorego | |n.gov --- Comment #1 from Samuel Sowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 201464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201464&action=edit Bug 42519: Updated terminology 'branch to 'library' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 Samuel Sowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201464|0 |1 is patch| | Attachment #201464|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 Samuel Sowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 --- Comment #2 from Samuel Sowanick <sam.sowanick@corvallisoregon.gov> --- To test: 1. go to Patron Categories, open a category and check "Self-renewal failure message" 2. Apply Patch 3. Check same message again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 201499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201499&action=edit Bug 42519: Terminology - Update 'branch' to 'library' in patron categories The default message in the "Self-renewal failure message" field (Administration > Patrons and circulation > Patron categories > Account expiry and self-renewal) uses incorrect terminology. Test plan: 1. Go to Administration > Patrons and circulation > Patron categories. 2. Click on a patron category. 3. Scroll down to the "Self-renewal failure message" field (in the Account expiry and self-renewal section). 4. Note the text says "...your local branch...". 5. Apply the patch. 6. Reload the page. 7. Note that the text now says "...your library...". Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #201464|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the terminology release notes| |used for the default | |message in the | |"Self-renewal failure | |message" field | |(Administration > Patrons | |and circulation > Patron | |categories > Account expiry | |and self-renewal). "...your | |local branch..." changed to | |"...your library...". Patch complexity|--- |String patch Assignee|oleonard@myacpl.org |sam.sowanick@corvallisorego | |n.gov --- Comment #4 from David Nind <david@davidnind.com> --- Thanks Samuel for the patch! I've signed off, but made some changes (to the commit message): 1. Updated the commit message (added the test plan and added a description - see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages ) 2. Added a release note. 3. Changed the patch complexity field to "String patch". 3. Changed the assignee for the bug to you. David Nind -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 --- Comment #6 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 201836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201836&action=edit Bug 42519: Terminology - Update 'branch' to 'library' in patron categories The default message in the "Self-renewal failure message" field (Administration > Patrons and circulation > Patron categories > Account expiry and self-renewal) uses incorrect terminology. Test plan: 1. Go to Administration > Patrons and circulation > Patron categories. 2. Click on a patron category. 3. Scroll down to the "Self-renewal failure message" field (in the Account expiry and self-renewal section). 4. Note the text says "...your local branch...". 5. Apply the patch. 6. Reload the page. 7. Note that the text now says "...your library...". Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Lisette Scheer <lisette@bywatersolutions.com> --- Looks good to me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201499|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42519 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org