[Bug 39208] New: printoverdues.sh requires unavailable cli tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 Bug ID: 39208 Summary: printoverdues.sh requires unavailable cli tool Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: alexander.wagner@desy.de QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz `printoverdues.sh` relies on `xhtml2pdf` for the conversion of a HTML document to a printable PDF version of said document. At time of writing, this tool dropped out of Debian (bookworm) and Ubuntu stable and sometimes older releases including backports and the like. Debian oldstable still keeps it, but no upstream releases beyond. This may endanger the functionality in Koha upstream. Possible solutions: - Manual installation outside the package management (and bugfixing) of the distribution via `pip`. That would also require a suitable documentation. - Use an alternative tool chain within the distributions (e.g. pandoc, if heading for a swiss army knife of format transformations. For PDF pandoc would require latex as "helper"). Note that `printoverdues.sh` is referred to explicitly in the implementation checklist. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Summary|printoverdues.sh requires |printoverdues.sh requires |unavailable cli tool |unavailable cli tool | |xhtml2pdf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 199518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199518&action=edit Bug 39208: Remove xhtml2pdf from printoverdues.sh Note: this requires a command line access to the test machine TEST PLAN: 1 - Anywhere on the computer running koha, run following command: mkdir tmp ./misc/cronjobs/printoverdues.sh tmp echo '<!DOCTYPE html><html><head><meta charset="UTF-8"></head><body><p>Тетрис — это классика!</p></body></html>' > tmp/tmp.html echo '* { color: red };' > tmp.css ./misc/cronjobs/printoverdues.sh tmp tmp.css 2 - Open the pdf in tmp/tmp.pdf, notice it is broken 3 - Apply patch 4 - Rerun ./misc/cronjobs/printoverdues.sh tmp tmp.css 5 - Open the pdf in tmp/tmp.pdf, notice it is now displaying properly, notice the css property still applies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 199519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199519&action=edit Bug 39208: Remove xhtml2pdf from printoverdues.sh Note: this requires a command line access to the test machine TEST PLAN: 1 - Anywhere on the computer running koha, run following command: mkdir tmp echo '<!DOCTYPE html><html><head><meta charset="UTF-8"></head><body><p>Тетрис — это классика!</p></body></html>' > tmp/tmp.html echo '* { color: red };' > tmp.css ./misc/cronjobs/printoverdues.sh tmp tmp.css 2 - Open the pdf in tmp/tmp.pdf, notice it is broken 3 - Apply patch 4 - Rerun ./misc/cronjobs/printoverdues.sh tmp tmp.css 5 - Open the pdf in tmp/tmp.pdf, notice it is now displaying properly, notice the css property still applies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 199521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199521&action=edit Bug 39208: Remove xhtml2pdf from printoverdues.sh Note: this requires a command line access to the test machine TEST PLAN: 1 - Anywhere on the computer running koha, run following command: mkdir tmp echo '<!DOCTYPE html><html><head><meta charset="UTF-8"></head><body><p>Тетрис — это классика!</p></body></html>' > tmp/tmp.html echo '* { color: red };' > tmp.css ./misc/cronjobs/printoverdues.sh tmp tmp.css 2 - Open the pdf in tmp/tmp.pdf, notice it is broken 3 - Apply patch 4 - Rerun ./misc/cronjobs/printoverdues.sh tmp tmp.css 5 - Open the pdf in tmp/tmp.pdf, notice it is now displaying properly, notice the css property still applies Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. From the /kohadevbox/koha directory: - create a new subdirectory: mkdir tmp - echo '<!DOCTYPE html><html><head><meta charset="UTF-8"></head><body><p>Тетрис — это классика!</p></body></html>' > tmp/tmp.html - echo '* { color: red };' > tmp/tmp.css ==> Result: a folder tmp with two files (tmp.css and tmp.html) 2. Run this command to generate the PDF: ./misc/cronjobs/printoverdues.sh tmp tmp/tmp.css ==> Result (because there is no xhtml2pdf): ./misc/cronjobs/printoverdues.sh: line 42: xhtml2pdf: command not found tar: tmp/*.pdf: Cannot stat: No such file or directory tar: Exiting with failure status due to previous errors 3. Apply the patch 4. Restart everything: restart_all 5. Repeat the command in step 2 ==> Result: a PDF in the tmp directory with the text in red -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199521|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 201813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201813&action=edit Bug 39208: Remove xhtml2pdf from printoverdues.sh Note: this requires a command line access to the test machine TEST PLAN: 1 - Anywhere on the computer running koha, run following command: mkdir tmp echo '<!DOCTYPE html><html><head><meta charset="UTF-8"></head><body><p>Тетрис — это классика!</p></body></html>' > tmp/tmp.html echo '* { color: red };' > tmp.css ./misc/cronjobs/printoverdues.sh tmp tmp.css 2 - Open the pdf in tmp/tmp.pdf, notice it is broken 3 - Apply patch 4 - Rerun ./misc/cronjobs/printoverdues.sh tmp tmp.css 5 - Open the pdf in tmp/tmp.pdf, notice it is now displaying properly, notice the css property still applies Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39208 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- This bug is very minor and applying the patch may have an impact on sent mails. Not backporting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org