[Bug 31526] New: Diff view on manage staged imports page is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Bug ID: 31526 Summary: Diff view on manage staged imports page is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: regression Severity: major Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org After importing a record that matched with an existing record, the Diff link is visible in the table of imported records. Clicking on it gives an error: Not a CODE reference at /kohadevbox/koha/tools/showdiffmarc.pl line 65 in (eval) at /kohadevbox/koha/tools/showdiffmarc.pl line 65 62: 63: if ( $type eq 'biblio' ) { 64: my $biblio = Koha::Biblios->find( $recordid ); 65: $record = $biblio->metadata->record->({ embed_items => 1 }); 66: $recordTitle = $biblio->title; 67: } 68: elsif ( $type eq 'auth' ) { -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- To test: * Export a record with ISBN from your catalog (Save as MARC) * Stage it using the ISBN matching rule (make sure it matched) * Manage staged import and click on the Diff link -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140561&action=edit Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140561|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140565&action=edit Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140565|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140696&action=edit Bug 31526: Follow-up for bug 29697 There was a typo in bug 29697 which lead to a code reference error. Test plan 1) Export a record with ISBN from your catalog (Save as MARC) 2) Stage it using the ISBN matching rule (make sure it matched) 3) Manage staged import and click on the Diff link Prior to this patch an error would be thrown, after the patch you should now get the diff view as expected again. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This kind of fixes should not stay too long in NSO or SO. I would even have recommended to move it to PQA directly, Martin. The RM will still see it. Anyway thanks for the fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31526 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org