[Bug 30921] New: Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Bug ID: 30921 Summary: Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org We should remove C4::XSLT::transformMARCXML4XSLT and instead utilise the coherent interface provided by RecordProcessor and the new ExpandCodedValues filter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30848 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 [Bug 30848] Introduce Koha::Filter::ExpandCodedFields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135778&action=edit Bug 30921: Replace C4::XSLT::transformMARCXML4XSLT with RecordProcessor This patch removes the last remaining uses of transformMARCXML4XSLT and replaced them with the equivilent RecordProcessor usage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Hi Martin. What is the best way to test this? - prove t/db_dependent/XSLT.t passes before and after the patch is applied - a git grep transformMARCXML4XSLT shows no occurrences after the patch is applied Since this is tied in with all the other dependencies, is there an overall test plan? David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Bug 30921 depends on bug 30848, which changed state. Bug 30848 Summary: Introduce Koha::Filter::ExpandCodedFields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Bug 30921 depends on bug 30744, which changed state. Bug 30744 Summary: Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi David, Yes, basically it's run prove as you suggest and then grep to ensure transfromMARCXML4XSLT hasn't crept back in anywhere. In general, to confirm there are no regressions in the UI, you can look at search results or detailed views on records in your catalog.. anything that's tied to an authorized value should look the same before and after the patch.. things like locations for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(... Applying: Bug 30921: Replace C4::XSLT::transformMARCXML4XSLT with RecordProcessor Using index info to reconstruct a base tree... M Koha/OAI/Server/Repository.pm Falling back to patching base and 3-way merge... Auto-merging Koha/OAI/Server/Repository.pm CONFLICT (content): Merge conflict in Koha/OAI/Server/Repository.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 30921: Replace C4::XSLT::transformMARCXML4XSLT with RecordProcessor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135778|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140350&action=edit Bug 30921: Replace C4::XSLT::transformMARCXML4XSLT with RecordProcessor This patch removes the last remaining uses of transformMARCXML4XSLT and replaced them with the equivilent RecordProcessor usage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140350|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 140354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140354&action=edit Bug 30921: Replace C4::XSLT::transformMARCXML4XSLT with RecordProcessor This patch removes the last remaining uses of transformMARCXML4XSLT and replaced them with the equivilent RecordProcessor usage. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): 1. Ran prove t/db_dependent/XSLT.t - tests should pass before and after the patch is applied 2. Ran git grep transformMARCXML4XSLT - should show no occurrences after the patch is applied. 3. Reviewed search results and a record details page before and after patch is applied, for both the staff interface and OPAC. There should be no differences in how the search results and individual record details page are displayed. (I searched for 'perl', and selected one record to view - compared side-by side in a new browser window.) Hope that is sufficient for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140354|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140477&action=edit Bug 30921: Replace C4::XSLT::transformMARCXML4XSLT with RecordProcessor This patch removes the last remaining uses of transformMARCXML4XSLT and replaced them with the equivilent RecordProcessor usage. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 --- Comment #9 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140478&action=edit Bug 30921: (QA follow-up) Remove unnecessary if The statement is already inside an if block with the same condition. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org