[Bug 31743] New: Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Bug ID: 31743 Summary: Cannot change my notice language when EnhancedMessagingPreferencesOPAC is off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org The combination of enabling TranslateNotices and disabling EnhancedMessagingPreferencesOPAC eliminates the possibility of changing language on OPAC user account. Note that we had both enabled and now we want to disable Enhanced on OPAC, but we loose the language. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141768&action=edit Bug 31743: Change condition for messaging tab Note for QA: The code for SMSnumber is still made dependent on EnhancedMessagingPreferencesOPAC in order to not disturb current behavior. This fixes Enhanced on, EnhancedOPAC off; the case of Enhanced off is not considered here. Test plan: Enable EnhancedMessaging, disable EnhancedMessagingOPAC. Enable TranslateNotices. Check if you can only change notice language on OPAC. Enable EnhancedMessagingOPAC. Check if you change messaging prefs too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |marie-luce.laflamme@inlibro | |.com --- Comment #2 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Suggestion for the test plan 1. Apply the patch 3. Enable EnhancedMessaging, disable EnhancedMessagingOPAC. 4. Enable TranslateNotices. 5. Login on the OPAC and go in "your messaging" 6. Check if you can only change notice language 7. Enable EnhancedMessagingOPAC. 8. Check if you can change messaging prefs too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141768|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 141849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141849&action=edit Bug 31743: Change condition for messaging tab Note for QA: The code for SMSnumber is still made dependent on EnhancedMessagingPreferencesOPAC in order to not disturb current behavior. This fixes Enhanced on, EnhancedOPAC off; the case of Enhanced off is not considered here. Test plan: Enable EnhancedMessaging, disable EnhancedMessagingOPAC. Enable TranslateNotices. Check if you can only change notice language on OPAC. Enable EnhancedMessagingOPAC. Check if you change messaging prefs too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: marie-luce <marie-luce.laflamme@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marie-Luce Laflamme from comment #2)
Suggestion for the test plan
1. Apply the patch 3. Enable EnhancedMessaging, disable EnhancedMessagingOPAC. 4. Enable TranslateNotices. 5. Login on the OPAC and go in "your messaging" 6. Check if you can only change notice language 7. Enable EnhancedMessagingOPAC. 8. Check if you can change messaging prefs too.
Thx Marie-Luce for signing off ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141849|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143024&action=edit Bug 31743: Change condition for messaging tab Note for QA: The code for SMSnumber is still made dependent on EnhancedMessagingPreferencesOPAC in order to not disturb current behavior. This fixes Enhanced on, EnhancedOPAC off; the case of Enhanced off is not considered here. Test plan: Enable EnhancedMessaging, disable EnhancedMessagingOPAC. Enable TranslateNotices. Check if you can only change notice language on OPAC. Enable EnhancedMessagingOPAC. Check if you change messaging prefs too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: marie-luce <marie-luce.laflamme@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org