[Bug 31654] New: Hide non-public libraries from MastheadLibraryPulldown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Bug ID: 31654 Summary: Hide non-public libraries from MastheadLibraryPulldown Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: domm@plix.at QA Contact: testopia@bugs.koha-community.org We have a few internal libraries (branches) that are used by librarians, but should not be visible to "normal" patrons (mostly because they cannot access those books). Currently there is no way to hide a library from the Masthead Pulldown or in the advanced search. Bug 27360 introduced the flag branches.public. This could be used to also hide the library from MastheadPulldown and the AdvancedSearch List. It seems that there is some additional / similar work going on in Bug 12242 Can we submit a patch that uses branches.public to hide libraries? Or should we wait what 27360 and 12242 will bring? Or can/should we also work on those tickets? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |domm@plix.at -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #1 from Thomas Klausner <domm@plix.at> --- Created attachment 141123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141123&action=edit do not list library in masthead and advanced search if branches.public is false (bug_31654_hide_nonpublic_libs) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Thomas Klausner <domm@plix.at> --- Test Plan: * Set OpacAddMastheadLibraryPulldown to "Add" * Go to Administration -> Libraries, edit "Fairfield", set "public" = "no" (at the end of the form) * Or connect to DB and run update branches set public = 0 where branchcode like 'F%'; This will set all three libraries starting with F to non-public * open OPAC * The "All libraries" Pulldown in the Header (between search slot and search button) still shows the non-public libraries * Go to OPAC -> Advanced Search, scroll to "Location and availability": The selectbox still shows the non-public libraries Now apply the patch * Open OPAC * The "All libraries" Pulldown in the Header now should not contain the libraries set to "public = no" * And in the Advanced Search "Location and availability" pulldown those libraries should also not be shown. Sponsored-by: Steiermärkische Landesbibliothek -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |minor Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12242 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- This is something I'm interested in as well. I don't have time for it this week, but I could probably test/QA it next week. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Hey Thomas, This will be a nice addition! There are a few problems with your patch: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL forbidden patterns forbidden pattern: tab char (line 235) * Commit title does not start with 'Bug XXXXX: ' - abec2a9a88 Can you make sure your commit title starts with "Bug 31654: " and have a look at the bad pattern in masthead.inc? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As you are just starting out: the QA tools script that points out these kind of errors can be run by everyone. On ktd it's just: 'qa -v 2'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #6 from Thomas Klausner <domm@plix.at> --- Created attachment 141335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141335&action=edit Bug 31654: Hide non-public libraries from MastheadLibraryPulldown (bug_31654_hide_nonpublic_libs) Do not list library in masthead and advanced search if branches.public is false Test Plan: * Set OpacAddMastheadLibraryPulldown to "Add" * Go to Administration -> Libraries, edit "Fairfield", set "public" = "no" (at the end of the form) * Or connect to DB and run update branches set public = 0 where branchcode like 'F%'; This will set all three libraries starting with F to non-public * open OPAC * The "All libraries" Pulldown in the Header (between search slot and search button) still shows the non-public libraries * Go to OPAC -> Advanced Search, scroll to "Location and availability": The selectbox still shows the non-public libraries Now apply the patch * Open OPAC * The "All libraries" Pulldown in the Header now should not contain the libraries set to "public = no" * And in the Advanced Search "Location and availability" pulldown those libraries should also not be shown. Sponsored-by: Steiermärkische Landesbibliothek -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Thomas Klausner <domm@plix.at> --- Hi Lucas! I now fixed the problems with the patch and submitted a new one. @Katrin Thanks for pointing out `qa-test-tools/koha-qa.pl` :-) Greetings, domm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141123|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Awesome, thanks Thomas! I did notice two things, neither of which are your fault. 1. Should we update the hint on branches.tt which currently reads "Set to 'yes' to show this library on the Libraries page in the OPAC." 2. I cannot set branches to public via administration. I filed a seperate bug for this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31688 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31785 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #9 from David Nind <david@davidnind.com> --- A temporary work around to making libraries not public until bug 31785 is in master (fixes MySQL strict mode issues) is to use SQL: update branches set public=0 where branchcode = XXX; Where XXX = code for library you want to make not public, such as CPL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #9)
A temporary work around to making libraries not public until bug 31785 is in master
This has now been pushed to master, so you should now be able to make a library not public. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141335|0 |1 is obsolete| | --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 142514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142514&action=edit Bug 31654: Hide non-public libraries from MastheadLibraryPulldown (bug_31654_hide_nonpublic_libs) Do not list library in masthead and advanced search if branches.public is false Test Plan: * Set OpacAddMastheadLibraryPulldown to "Add" * Go to Administration -> Libraries, edit "Fairfield", set "public" = "no" (at the end of the form) * Or connect to DB and run update branches set public = 0 where branchcode like 'F%'; This will set all three libraries starting with F to non-public * open OPAC * The "All libraries" Pulldown in the Header (between search slot and search button) still shows the non-public libraries * Go to OPAC -> Advanced Search, scroll to "Location and availability": The selectbox still shows the non-public libraries Now apply the patch * Open OPAC * The "All libraries" Pulldown in the Header now should not contain the libraries set to "public = no" * And in the Advanced Search "Location and availability" pulldown those libraries should also not be shown. Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Claude <claude.demeure@mailo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Claude Demeure <claude.demeure@mailo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claude.demeure@mailo.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@koha-suomi.fi --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 12242 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142514|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143117&action=edit Bug 31654: Hide non-public libraries from MastheadLibraryPulldown (bug_31654_hide_nonpublic_libs) Do not list library in masthead and advanced search if branches.public is false Test Plan: * Set OpacAddMastheadLibraryPulldown to "Add" * Go to Administration -> Libraries, edit "Fairfield", set "public" = "no" (at the end of the form) * Or connect to DB and run update branches set public = 0 where branchcode like 'F%'; This will set all three libraries starting with F to non-public * open OPAC * The "All libraries" Pulldown in the Header (between search slot and search button) still shows the non-public libraries * Go to OPAC -> Advanced Search, scroll to "Location and availability": The selectbox still shows the non-public libraries Now apply the patch * Open OPAC * The "All libraries" Pulldown in the Header now should not contain the libraries set to "public = no" * And in the Advanced Search "Location and availability" pulldown those libraries should also not be shown. Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Claude Demeure <claude.demeure@mailo.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143118&action=edit Bug 31654: (follow-up) Update hint This patch updates the 'public' hint to include the additional functionality we now tie to it. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work, QA scripts are happy and I added the minor follow-up to clarify the hint when enabled/disabling the public option. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org