[Bug 12211] New: Wrong home link in bootstrap opac-auth
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Bug ID: 12211 Summary: Wrong home link in bootstrap opac-auth Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 28030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28030&action=edit Bug 12211 - Wrong home link in bootstrap opac-auth In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. Test plan : - Use boostrap opac theme - Go to cgi-bin/koha/opac-user.pl when not logged => without patch, clicking on Home does not change the page => with patch, clicking on Home leads to opac-main.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- This template file is called from Auth.pm, try a fake (opac) login and you will end with this page. Patch is ok, but to really look like the others, it needs to go from this <li><a href="#">Home</a> <span class="divider">›</span></li> <li>Log in</li> to this <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li> <li><a href="#">Log in</a></li> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28030|0 |1 is obsolete| | --- Comment #3 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 28332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28332&action=edit Bug 12211 - Wrong home link in bootstrap opac-auth In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. Test plan : - Use boostrap opac theme - Go to cgi-bin/koha/opac-user.pl when not logged => without patch, clicking on Home does not change the page => with patch, clicking on Home leads to opac-main.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 --- Comment #4 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #2) Here is new patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 28332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28332 Bug 12211 - Wrong home link in bootstrap opac-auth Review of attachment 28332: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12211&attachment=28332) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt @@ +14,5 @@
<div class="main"> <ul class="breadcrumb"> + <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li> + <li><a href="#">Log in</a></li>
Is there a reason you added the href? The title says wrong home link. It says nothing about missing a link on "Log in". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28332|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28336&action=edit [SIGNED-OFF] Bug 12211 - Wrong home link in bootstrap opac-auth In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. Test plan : - Use boostrap opac theme - Go to cgi-bin/koha/opac-user.pl when not logged => without patch, clicking on Home does not change the page => with patch, clicking on Home leads to opac-main.pl Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Link ok, no errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to M. Tompsett from comment #5)
Comment on attachment 28332 [details] [review]
Is there a reason you added the href? The title says wrong home link. It says nothing about missing a link on "Log in".
Just consistency :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28336|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 28398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28398&action=edit [PASSED QA] Bug 12211 - Wrong home link in bootstrap opac-auth In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads to #, it should lead to opac-main.pl like in all other pages. Test plan : - Use boostrap opac theme - Go to cgi-bin/koha/opac-user.pl when not logged => without patch, clicking on Home does not change the page => with patch, clicking on Home leads to opac-main.pl Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Link ok, no errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master and 3.16.x. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 --- Comment #10 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.12. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org