[Bug 39144] New: OPAC virtual card page is missing custom CSS from OPACUserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 Bug ID: 39144 Summary: OPAC virtual card page is missing custom CSS from OPACUserCSS Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jrobb@sekls.org QA Contact: testopia@bugs.koha-community.org Custom CSS is not applied to the OPAC virtual card page (opac-virtual-card.pl). To replicate: 1. Set OPACVirtualCard syspref to Allow 2. Add an obvious change to OPACUserCSS syspref ( body {background-color: pink;} ) 3. Switch to the OPAC, notice the CSS is in effect 4. Log in and go to 'Your account' then 'My virtual card' from the menu on the left 5. Notice the custom CSS is no longer in effect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Good catch! Funny story... it looks like OPACUserCSS is being rendered in the HTML, but the OPAC virtual card page mistakenly applies the opac.css twice. Once before and once after OPACUserCSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 178129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178129&action=edit Bug 39144: Remove second call to opac.css This change removes an unnecessary second call to opac.css on the opac-virtual-card.pl page. Test plan: 1. Set OPACVirtualCard syspref to Allow 2. Add an obvious change to OPACUserCSS syspref ( body {background-color: pink;} ) 3. Switch to the OPAC, notice the CSS is in effect 4. Log in and go to 'Your account' then 'My virtual card' from the menu on the left 5. Notice the custom CSS affects the virtual card page too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178129|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 178300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178300&action=edit Bug 39144: Remove second call to opac.css This change removes an unnecessary second call to opac.css on the opac-virtual-card.pl page. Test plan: 1. Set OPACVirtualCard syspref to Allow 2. Add an obvious change to OPACUserCSS syspref ( body {background-color: pink;} ) 3. Switch to the OPAC, notice the CSS is in effect 4. Log in and go to 'Your account' then 'My virtual card' from the menu on the left 5. Notice the custom CSS affects the virtual card page too Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178300|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178450&action=edit Bug 39144: Remove second call to opac.css This change removes an unnecessary second call to opac.css on the opac-virtual-card.pl page. Test plan: 1. Set OPACVirtualCard syspref to Allow 2. Add an obvious change to OPACUserCSS syspref ( body {background-color: pink;} ) 3. Switch to the OPAC, notice the CSS is in effect 4. Log in and go to 'Your account' then 'My virtual card' from the menu on the left 5. Notice the custom CSS affects the virtual card page too Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39144 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org