[Bug 38794] New: AggregatedFullText description should be Aggregated full text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Bug ID: 38794 Summary: AggregatedFullText description should be Aggregated full text Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com in ERM_PACKAGE_CONTENT_TYPE auth values, AggregatedFullText description is currently "Aggregated full" it should be "Aggregated full text" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.hunstein@bsz-bw.de Assignee|jonathan.druart@gmail.com |nicolas.hunstein@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 --- Comment #1 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 176328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176328&action=edit Bug 38794: update AggregatedFullText description updates description "Aggregated full" to "Aggregated full text" at authorized value ERM_PACKAGE_CONTENT_TYPE to test: - go to Administration/Authorized values - check authorized values for category ERM_PACKAGE_CONTENT_TYPE - verify description for AggregatedFullText is Aggregated full - apply patch - reset database or reset_all - verify description has changed to Aggregated full text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176328|0 |1 is obsolete| | --- Comment #2 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 176329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176329&action=edit Bug 38794: update AggregatedFullText description updates description "Aggregated full" to "Aggregated full text" at authorized value ERM_PACKAGE_CONTENT_TYPE to test: - go to Administration/Authorized values - check authorized values for category ERM_PACKAGE_CONTENT_TYPE - verify description for AggregatedFullText is Aggregated full - apply patch - reset database or reset_all - verify description has changed to Aggregated full text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m Status|Needs Signoff |Failed QA --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This is missing an atomic update. Kohas that are upgrading also need this description updated: update authorised_values set lib = "Aggregated full text" where category = "ERM_PACKAGE_CONTENT_TYPE" AND authorised_value="AggregatedFullTex t"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #3)
This is missing an atomic update. Kohas that are upgrading also need this description updated: update authorised_values set lib = "Aggregated full text" where category = "ERM_PACKAGE_CONTENT_TYPE" AND authorised_value="AggregatedFullTex t";
The value might have been translated and this would untranslate them. Suggestion: Add the English description to the WHERE clauses as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #4)
The value might have been translated and this would untranslate them. Suggestion: Add the English description to the WHERE clauses as well.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176329|0 |1 is obsolete| | --- Comment #6 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 176345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176345&action=edit Bug 38794: update AggregatedFullText description updates description "Aggregated full" to "Aggregated full text" at authorized value ERM_PACKAGE_CONTENT_TYPE to test: - go to Administration/Authorized values - check authorized values for category ERM_PACKAGE_CONTENT_TYPE - verify description for AggregatedFullText is Aggregated full - apply patch - reset database or reset_all - verify description has changed to Aggregated full text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 --- Comment #7 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 176346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176346&action=edit Bug 38794: (follow-up) add database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 176405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176405&action=edit Bug 38794: Update authorized value description for AggregatedFullText Update the authorized value description for AggregatedFullText in the ERM_PACKAGE_CONTENT_TYPE category from "Aggregated full" to "Aggregated full text". Test plan: 1. Go to Administration > Authorized values. 2. Check the authorized values for the ERM_PACKAGE_CONTENT_TYPE category. 3. Note that the description for AggregatedFullText is "Aggregated full". 4. Apply the patch. 5. Update the database: updatedatabase (Bonus: To check for new installations: reset_all) 6. Refresh the page and note that the description is now "Aggregated full text". Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 176406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176406&action=edit Bug 38794: (follow-up) Add database update Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #176345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176346|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the authorized release notes| |value description for | |AggregatedFullText in the | |ERM_PACKAGE_CONTENT_TYPE | |category. It updates the | |description from | |"Aggregated full" to | |"Aggregated full text". --- Comment #10 from David Nind <david@davidnind.com> --- The database update didn't work, as the SQL statement was split across lines in the file. I've fixed the database patch to correct this. I also edited the commit messages and added a release note - hope you don't mind! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176405|0 |1 is obsolete| | Attachment #176406|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176951&action=edit Bug 38794: Update authorized value description for AggregatedFullText Update the authorized value description for AggregatedFullText in the ERM_PACKAGE_CONTENT_TYPE category from "Aggregated full" to "Aggregated full text". Test plan: 1. Go to Administration > Authorized values. 2. Check the authorized values for the ERM_PACKAGE_CONTENT_TYPE category. 3. Note that the description for AggregatedFullText is "Aggregated full". 4. Apply the patch. 5. Update the database: updatedatabase (Bonus: To check for new installations: reset_all) 6. Refresh the page and note that the description is now "Aggregated full text". Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176952&action=edit Bug 38794: (follow-up) Add database update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176953&action=edit Bug 38794: say_success only if updated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | Status|Pushed to main |Pushed to stable CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- There is a typo on main on dbrev commit, it is named "Bug 28794" Fixed on 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38794 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org