[Bug 21528] New: Combine all reserves in a biblio hold-group into a single line entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Bug ID: 21528 Summary: Combine all reserves in a biblio hold-group into a single line entry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Building on the 'reserve next available from a group' functionality implemented in bug 15516 the patches attached to this bug report should combine all the reserves in a hold-group on a biblio into a single line entry on the following interfaces: * reserve/request.pl * Reserves tab in the circ/circulation.pl * members/moremember.pl This will make the reserve queue display manageable and not too overly long -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80317&action=edit Bug 21528: Display reserves in hold_group as single row in template -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80317|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80319&action=edit Bug 21528: Display reserves in hold_group as single row in template Sponsored-By: Brimbank library, Australia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80319|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80376&action=edit Bug 21528: Single line for hold groups in intranet side Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80376|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80443&action=edit Bug 21528: Single line for hold groups in intranet side Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80443|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 88042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88042&action=edit Bug 21528: UNFINISHED PATCH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88042|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 88124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88124&action=edit Bug 21528: UNFINISHED PATCH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 88124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88124 Bug 21528: UNFINISHED PATCH Review of attachment 88124: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21528&attachment=88124) ----------------------------------------------------------------- ::: svc/holds @@ +103,2 @@
itemtype_limit => $itemtype_limit, + hold_group => Koha::Holds->search({ hold_group_id => $h->hold_group_id })->unblessed,
This is buggy. I'd suggest changing it to the following: ( $h->hold_group_id ) ? Koha::Holds->search({ hold_group_id => $h->hold_group_id })->unblessed : undef If the hold doesn't have a hold group ID, all holds without a hold_group_id will be fetched. If a borrower has a high number of holds, and there are a high number of holds on the system, you'll be fetching and then transmitting a huge amount of data (the magnitude being megabytes instead of kilobytes). This uses up a lot of system memory and creates huge latency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org