[Bug 31146] New: Minor UI problem in recalls history in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Bug ID: 31146 Summary: Minor UI problem in recalls history in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org This is very minor, but I figured it might make an easy fix for someone... When recalls are turned on, the patron has access to their recalls history in their online account. If the OPAC is multilingual, the language switcher is right under the recalls history table, rather than being at the bottom of the page where it normally is. To test: 1) Install another language and enable it in the OPACLanguages system preference 2) Also make sure opaclanguagesdisplay is set to Allow 3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only) 4) Turn on recalls 4.1) In Administration > Global system preferences, enable UseRecalls 4.2) Add recalls permissions in your circulation rules 5) In the OPAC, log in as a patron 6) Find a record with checked out items and place a recall 7) Go to your account --> Note that the language switch is at the bottom left of the screen 8) Click on any tab in the patron's account --> Note that the language switch is at the bottom left of the screen 9) Click on 'Your recalls history' --> Note that the language switch is right under the recalls history table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 137658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137658&action=edit Recalls history page wth language switch in wrong place This is a screenshot of the recalls history page in the patron's online account. Note that the language switch is right under the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 137659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137659&action=edit Holds history page for comparison This is a screenshot of the holds history page in the patron's online account. Note that the language switch is at the bottom left. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- There is a small mistake in the markup, an unclosed table element. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 137732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137732&action=edit Bug 31146: Fix unclosed table element To test: 1) Install another language and enable it in the OPACLanguages system preference 2) Also make sure opaclanguagesdisplay is set to Allow 3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only) 4) Turn on recalls 4.1) In Administration > Global system preferences, enable UseRecalls 4.2) Add recalls permissions in your circulation rules 5) In the OPAC, log in as a patron 6) Find a record with checked out items and place a recall 7) Go to your account --> Note that the language switch is at the bottom left of the screen 8) Click on any tab in the patron's account --> Note that the language switch is at the bottom left of the screen 9) Click on 'Your recalls history' --> Note that the language switch is right under the recalls history table 10) Apply patch 11) The changelanguage div should now be properly placed at the bottom of the page. https://bugs.koha-community.org/show_bug.cgi?id=31153 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137732|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 137735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137735&action=edit Bug 31146: Fix unclosed table element To test: 1) Install another language and enable it in the OPACLanguages system preference 2) Also make sure opaclanguagesdisplay is set to Allow 3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only) 4) Turn on recalls 4.1) In Administration > Global system preferences, enable UseRecalls 4.2) Add recalls permissions in your circulation rules 5) In the OPAC, log in as a patron 6) Find a record with checked out items and place a recall 7) Go to your account --> Note that the language switch is at the bottom left of the screen 8) Click on any tab in the patron's account --> Note that the language switch is at the bottom left of the screen 9) Click on 'Your recalls history' --> Note that the language switch is right under the recalls history table 10) Apply patch 11) The changelanguage div should now be properly placed at the bottom of the page. https://bugs.koha-community.org/show_bug.cgi?id=31153 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks for this Lucas! It works perfectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137735|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137766&action=edit Bug 31146: Fix unclosed table element To test: 1) Install another language and enable it in the OPACLanguages system preference 2) Also make sure opaclanguagesdisplay is set to Allow 3) Make sure OpacLangSelectorMode is set to display the switch in the footer (either top and bottom or footer only) 4) Turn on recalls 4.1) In Administration > Global system preferences, enable UseRecalls 4.2) Add recalls permissions in your circulation rules 5) In the OPAC, log in as a patron 6) Find a record with checked out items and place a recall 7) Go to your account --> Note that the language switch is at the bottom left of the screen 8) Click on any tab in the patron's account --> Note that the language switch is at the bottom left of the screen 9) Click on 'Your recalls history' --> Note that the language switch is right under the recalls history table 10) Apply patch 11) The changelanguage div should now be properly placed at the bottom of the page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice quick fixing there.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Bakported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Recalls feature not present in 21.11.x. this bug is not relevant to backport in 21.11.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org