https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Ok If I checkout the branch it fails Failed test 'Single Gir field OK' # at t/Ediorder.t line 104. # got: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM' # expected: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM' Use of uninitialized value $lsq_field in hash element at /home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563. Use of uninitialized value $lsq_field in hash element at /home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563. Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t line 117. # Failed test 'First part of split Gir field OK' # at t/Ediorder.t line 117. # got: undef # expected: 'GIR+002+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM' Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t line 123. # Failed test 'Second part of split GIR field OK' # at t/Ediorder.t line 123. # got: undef # expected: 'GIR+002+S_I:LVT' # Looks like you failed 3 tests of 13. This is because this test is now db_dependent Koha/Edifact/Order.pm: my $lsq_field = C4::Context->preference('EdifactLSQ'); So it needs to probably be moved out of t, or that syspref needs to be mocked. The reason it works is if that syspref is set location. If I set the syspref to collection, the tests fail, if i set it location the tests pass. The problem is then when you are building a package you dont have a database, the t/ tests should all pass without relying on a syspref fetched from a db. Chris -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137710&action=edit Bug 31134: Mock EdifactLSQ for t/Edifact.t This patch adds a mock for the EdifactLSQ preference so we can consistently pass when a database is not available. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for drawing my attention to this one.. should work with the patch attached :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137710|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137711&action=edit Bug 31134: Mock EdifactLSQ for t/Edifact.t This patch adds a mock for the EdifactLSQ preference so we can consistently pass when a database is not available. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137711|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137714&action=edit Bug 31134: Mock EdifactLSQ for t/Edifact.t This patch adds a mock for the EdifactLSQ preference so we can consistently pass when a database is not available. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |arthur.suzuki@biblibre.com Resolution|--- |FIXED --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- depends on 30135 not released in 21.11.x. won't backport. -- You are receiving this mail because: You are watching all bug changes.