[Bug 11123] New: 2 routines are unused in C4::Account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 Bug ID: 11123 Summary: 2 routines are unused in C4::Account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org C4::Accounts::fixcredit and C4::Accounts::refund are marked as deprecated and are not used. They can be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22308&action=edit Bug 11123: 2 routines are unused in C4::Account C4::Accounts::fixcredit and C4::Accounts::refund are marked as deprecated and are not used. They can be removed. Use: git grep fixcredit git rgep refund and verify these routines are not currently in used. Bonus: The module exports reconcileaccount which is not defined. The export is removed too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- I noticed that a function call to the refund was commented out in C4::Accounts, having not even read the patch. I did a: git blame -L440,450 C4/Accounts.pm to discover that the commit in question was likely done in 2008. So, the second and third blocks displayed in the patches "Diff" have about 5 years old. I don't see a problem with them. I went brute force and did a: grep fixcredit `find .` And the only code found was C4::Accounts. This included: the commented line, two POD lines, and the function definition line. I see no reason not to remove fixcredit. When I did the same for refund, it was messier, so I hoped that the git grep provided was cleaner. It basically was the same thing, except piped to less. C4::Accounts has 3 lines related to the deprecated function refund. I ignored the blib and po results. There were unrelated results in the stats.screen.pl, sysprefs.sql, updatedatabase.pl, and various template files. As far as I can see, there is nothing using the refund function in C4::Accounts. There is only one reference to reconcileaccount, which is the line that is exporting it. That makes no sense, so I see no reason to prevent removal. In short, this patch is good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 22319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22319&action=edit [SIGNED OFF] Bug 11123: 2 routines are unused in C4::Account C4::Accounts::fixcredit and C4::Accounts::refund are marked as deprecated and are not used. They can be removed. Use: git grep fixcredit git grep refund and verify these routines are not currently in used. Bonus: The module exports reconcileaccount which is not defined. The export is removed too. MLT: Ran qa tool on this patch with no issues either. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22308|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 22352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22352&action=edit Bug 11123: 2 routines are unused in C4::Account C4::Accounts::fixcredit and C4::Accounts::refund are marked as deprecated and are not used. They can be removed. Use: git grep fixcredit git grep refund and verify these routines are not currently in used. Bonus: The module exports reconcileaccount which is not defined. The export is removed too. MLT: Ran qa tool on this patch with no issues either. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22319|0 |1 is obsolete| | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org