[Bug 8199] New: Search results are contained into a table html element
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Priority: P5 - low Change sponsored?: --- Bug ID: 8199 Assignee: oleonard@myacpl.org Summary: Search results are contained into a table html element Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart@biblibre.com Hardware: All Status: NEW Version: unspecified Component: Templates Product: Koha It would be better to change the structure of opac-results.tt and catalogue/results.tt by replacing "table" elements with a more ergonomic structure (like div, span, etc.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9956&action=edit Bug 8199 : Replace table in opac-results with div Test plan: launch a query from your opac search form and compare results before and after applying this patch. Normally, You don't show a lot of differences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch is a first draft. I would like to have feed back about this patch before to continue (and to adapt to catalogue/results.tt) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I don't think there's anything inherently more ergonomic about showing search results in divs instead of tables, so I'd be interested in seeing a test case that shows how this makes things more flexible. Is the goal to be able to rearrange the elements somehow? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9956|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10247&action=edit Bug 8199 : Replace table in opac-results with div -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Owen, For example: currently (with the table structure) it is not possible to move the image from right to left. With this patch, we can filled the OPACUserCSS syspref with: .result > input { float: none; } .result > span { float: none; margin-left: 5px; } .all_results > div > span.biblio_infos { display: block; max-width: 80%; padding-left: 120px; margin-top: -15px; } .result > span.image { margin-left: 30px; margin-top: -70px; position: absolute; } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I noticed two problems with this: 1. The numbers on the left are run into the main results block. 2. Some of the images (possibly local cover images?) wrap to the next line. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- I don't plan to work on it. Reopen if someone is interested. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org