[Bug 34010] New: Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Bug ID: 34010 Summary: Template corrections to recall pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 19532 The recall pages have not been updated to use the wrapper for breadcrumbs and many lack a .page-section container div. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152350&action=edit Bug 34010: Template corrections to recall pages This patch makes some corrections to recall pages: - Update breadcrumbs menu to use wrapper. - Add <div class="page-section"> where it is missing. - Use biblio-title include to show links to bibliographic record titles. - Correct Bootstrap button dropdown markup for consistent style - Change some submit buttons to <button> elements for consistent style To test you must have UseRecalls enabled. Having some sample recalls data will help. Check the following pages to confirm that everything looks correct: - Circulation -> - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Existing recalls: View a bibliographic record with a recall and click "Recalls" in the sidebar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 152357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152357&action=edit Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |samalau@gmail.com --- Comment #3 from Sam Lau <samalau@gmail.com> --- (In reply to Sam Lau from comment #2)
Created attachment 152357 [details] [review] Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup
This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation.
Note: this patch includes indentation changes, so check the diff accordingly.
To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup.
Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly.
Signed-off-by: Sam Lau <samalau@gmail.com>
Oops, attached wrong one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152350|0 |1 is obsolete| | Attachment #152357|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau@gmail.com> --- Created attachment 152359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152359&action=edit Bug 34010: Template corrections to recall pages This patch makes some corrections to recall pages: - Update breadcrumbs menu to use wrapper. - Add <div class="page-section"> where it is missing. - Use biblio-title include to show links to bibliographic record titles. - Correct Bootstrap button dropdown markup for consistent style - Change some submit buttons to <button> elements for consistent style To test you must have UseRecalls enabled. Having some sample recalls data will help. Check the following pages to confirm that everything looks correct: - Circulation -> - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Existing recalls: View a bibliographic record with a recall and click "Recalls" in the sidebar. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152359|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152595&action=edit Bug 34010: Template corrections to recall pages This patch makes some corrections to recall pages: - Update breadcrumbs menu to use wrapper. - Add <div class="page-section"> where it is missing. - Use biblio-title include to show links to bibliographic record titles. - Correct Bootstrap button dropdown markup for consistent style - Change some submit buttons to <button> elements for consistent style To test you must have UseRecalls enabled. Having some sample recalls data will help. Check the following pages to confirm that everything looks correct: - Circulation -> - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Existing recalls: View a bibliographic record with a recall and click "Recalls" in the sidebar. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Bug 34010 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org