https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 [Bug 33992] Only consider the date when labelling a waiting recall as problematic -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152286|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 152311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152311&action=edit Bug 33990: Correctly access subtitle for Recalls awaiting pickup report This patch fixes how the bibliographic record's subtitle is fetched to prevent the page from exploding when viewing the recalls awaiting pickup for a problematic number of days. To test: 1. Enable UseRecalls syspref and set the relevant circulation and fines rules to configure recalls 2. Set the RecallsMaxPickUpDelay to 1 day 3. Check out Item A to Patron A 4. Log into the OPAC as Patron B 5. Search for Item A and place a recall 6. Log back into the staff interface and check in Item A 7. Confirm the recall as waiting for Patron B 8. Go to Circulation -> Recalls awaiting pickup 9. Confirm your recall exists under the 'Recalls waiting' tab 10. Change the waiting_date in the database for this recall to a few days ago so we would expect to see it under the 'Recalls waiting over 1 days' tab sudo koha-mysql INSTANCE select * from recalls; # to get the recall_id update recalls set waiting_date = "2023-06-10 03:54:21" where recall_id = X; 11. Refresh the Circulation -> Recalls awaiting pickup page 12. Confirm the page blows up and there is an error 13. Apply the patch and refresh the page 14. Confirm the page loads successfully and your recall is showing as expected under the 'Recalls waiting over 1 days' tab 15. Confirm the subtitle (probably in 245$b) shows as expected Sponsored-by: Auckland University of Technology Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Fix the 'Recalls awaiting |Fix 'Recalls awaiting |pickup' report if there are |pickup' report if there are |recalls waiting a |recalls waiting a |problematic number of days |problematic number of days -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152311|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152602&action=edit Bug 33990: Correctly access subtitle for Recalls awaiting pickup report This patch fixes how the bibliographic record's subtitle is fetched to prevent the page from exploding when viewing the recalls awaiting pickup for a problematic number of days. To test: 1. Enable UseRecalls syspref and set the relevant circulation and fines rules to configure recalls 2. Set the RecallsMaxPickUpDelay to 1 day 3. Check out Item A to Patron A 4. Log into the OPAC as Patron B 5. Search for Item A and place a recall 6. Log back into the staff interface and check in Item A 7. Confirm the recall as waiting for Patron B 8. Go to Circulation -> Recalls awaiting pickup 9. Confirm your recall exists under the 'Recalls waiting' tab 10. Change the waiting_date in the database for this recall to a few days ago so we would expect to see it under the 'Recalls waiting over 1 days' tab sudo koha-mysql INSTANCE select * from recalls; # to get the recall_id update recalls set waiting_date = "2023-06-10 03:54:21" where recall_id = X; 11. Refresh the Circulation -> Recalls awaiting pickup page 12. Confirm the page blows up and there is an error 13. Apply the patch and refresh the page 14. Confirm the page loads successfully and your recall is showing as expected under the 'Recalls waiting over 1 days' tab 15. Confirm the subtitle (probably in 245$b) shows as expected Sponsored-by: Auckland University of Technology Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This patch is no longer needed, bug is fixed upstream -- You are receiving this mail because: You are watching all bug changes.