[Bug 21356] New: Missing space in parcel.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 Bug ID: 21356 Summary: Missing space in parcel.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org Created attachment 78878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78878&action=edit Screen capture of the place where the space is missing There is no space between the user's name and "On:" (see screen capture) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 78880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78880&action=edit Bug 21356: Missing space in parcel.tt This patch adds a space between the user's name and 'On:' in parcel.tt. To test: 1) Go to Acquisitions 2) Search for a vendor 3) Create a new basket 4) Add an order to the basket 5) Close the basket 6) Receive the order 7) In the page title 'Receipt summary' notice there is no space between the 'Received by' user name and 'On:' 8) Apply the patch 9) Refresh the page, there should now be a space -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caroline, is this ready for testing? Do not forget to switch the status to Needs Signoff as well as assign the bug report to you ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com Status|NEW |Needs Signoff --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Right sorry! It is only my 2nd submission... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78880|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 78938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78938&action=edit Bug 21356: Missing space in parcel.tt This patch adds a space between the user's name and 'On:' in parcel.tt. To test: 1) Go to Acquisitions 2) Search for a vendor 3) Create a new basket 4) Add an order to the basket 5) Close the basket 6) Receive the order 7) In the page title 'Receipt summary' notice there is no space between the 'Received by' user name and 'On:' 8) Apply the patch 9) Refresh the page, there should now be a space Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78938|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78940&action=edit Bug 21356: Add Missing space in parcel.tt This patch adds a space between the user's name and 'On:' in parcel.tt. To test: 1) Go to Acquisitions 2) Search for a vendor 3) Create a new basket 4) Add an order to the basket 5) Close the basket 6) Receive the order 7) In the page title 'Receipt summary' notice there is no space between the 'Received by' user name and 'On:' 8) Apply the patch 9) Refresh the page, there should now be a space Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21356 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Useless for 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org