[Bug 21262] New: Do not format numbers for editing if too big
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Bug ID: 21262 Summary: Do not format numbers for editing if too big Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Same fix as bug 15770 except for fields used for editing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78098&action=edit Bug 21262: Do not format numbers for editing if too big This patch copies the code from bug 15770 to the format_for_editing sub. It also corrects schema issue, listing the purpose for two acq columns instead of claing unused To test: 1 - Edit a fund 2 - Set warning at amount to: 100000000000000 3 - Save budget 4 - Try to edit - internal server error 5 - Apply patch 6 - Should be able to edit budget 7 - Number should appear unformatted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |nick@bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15770 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78098|0 |1 is obsolete| | --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 78928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78928&action=edit Bug 21262: Do not format numbers for editing if too big This patch copies the code from bug 15770 to the format_for_editing sub. It also corrects schema issue, listing the purpose for two acq columns instead of claing unused To test: 1 - Edit a fund 2 - Set warning at amount to: 100000000000000 3 - Save budget 4 - Try to edit - internal server error 5 - Apply patch 6 - Should be able to edit budget 7 - Number should appear unformatted Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Works! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78928|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78941&action=edit Bug 21262: Do not format numbers for editing if too big This patch copies the code from bug 15770 to the format_for_editing sub. It also corrects schema issue, listing the purpose for two acq columns instead of claing unused To test: 1 - Edit a fund 2 - Set warning at amount to: 100000000000000 3 - Save budget 4 - Try to edit - internal server error 5 - Apply patch 6 - Should be able to edit budget 7 - Number should appear unformatted Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> 2 quick notes: 1. Code must be moved to a subroutine if reused later 2. It would have prefered to have the comment of the 2 DB columns on a separate patch (even separate bug report). As it's minor and that the patch will certainly backported I will not block it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x fro 18.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21262 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org