http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3550 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8035|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8180&action=edit Bug 5596 [REVISED] add author to holds to pull report Adding output of author and, for good measure, subtitle. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8180|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 8187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8187&action=edit Bug 5596 [REVISED] add author to holds to pull report Adding output of author and, for good measure, subtitle. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Passes tests, author and subtitle shown on holds to pull report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |koha.sekjal@gmail.com --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Adding author is easy enough; requires a template only change, since the value is already pulled in the SQL. Unfortunately, the addition of subtitle introduces n calls to GetMarcBiblio, where n = number of pending reserves. This is a serious performance killer, as it requires parsing each MARCXML record to extract the subtitle. Given that subtitle is not part of the original request of this bug report, and it'll cost a lot of extra CPU cycles to extract it, I'm marking this patch as Failed QA. Please submit a separate bug report for adding subtitle to the holds to pull report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I agree that I broke the rules in including an additional change, but I disagree that extra CPU cycles is a reason why a change like this might be rejected. Using GetMarcBiblio is currently the ONLY way we have to get subtitle, for better or worse. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Kristina <khspaces-subscriptions@yahoo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |khspaces-subscriptions@yaho | |o.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #7)

I agree that I broke the rules in including an additional change, but I disagree that extra CPU cycles is a reason why a change like this might be rejected. Using GetMarcBiblio is currently the ONLY way we have to get subtitle, for better or worse.

Agreeing with Owen and Ian in fact... My feeling is that an acceptable circumventing would be to memoize the GetMarcBiblio sub. Once it's done, subsequent calls to the function will cost nothing (note : I've said memoize, not memoize with memcache, as this 2nd option will give a longer persistency, but at the -heavy- price of a http call to memcached) The best/long term option would be to use a good ORM & internal caching & things like that, but they are not close. patch pushed (that removes subtitle, that was already here before the patch)) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |rel_3_8 --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Will not be pushed to 3.6.x. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.