[Bug 25238] New: Accessibility: Multiple 'H1' headings exist in the full record display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Bug ID: 25238 Summary: Accessibility: Multiple 'H1' headings exist in the full record display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: oleonard@myacpl.org, testopia@bugs.koha-community.org Depends on: 25237 Blocks: 25150 Library Catalogue - OPAC Multiple level-one headings are present on the book title page. This means that screen reader users may not be able to determine which level-one heading introduces the topic or subject of the page content. 1/ Search for an item 2/ Click through to a records full details disaply Current Code: <h1 id="logo"> <a class="brand" href="/cgi-bin/koha/opac-main.pl"> Library name</a> </h1> <h1 class="title" property="name">Taxing time for housing </h1> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 [Bug 25150] Accessibility: 2.4.10 Section Headings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25237 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105733&action=edit Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk, | |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25150 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 [Bug 25150] Accessibility: 2.4.10 Section Headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105733|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105742&action=edit Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe there was some discussion about the logo having h1 - was there any conclusion if we should change it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105742|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106117&action=edit Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #3)
I believe there was some discussion about the logo having h1 - was there any conclusion if we should change it?
I think we decided it would be good to change it, but not with this particular set of bugs as it needs more thought going into how we arrange subsequent headings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in| |19.11.08 --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08 |19.11.08, 19.05.14 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org