[Bug 25236] New: Accessibility: The 'Refine your search' box contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Bug ID: 25236 Summary: Accessibility: The 'Refine your search' box contains semantically incorrect headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: oleonard@myacpl.org, testopia@bugs.koha-community.org Depends on: 25155 Blocks: 25150 Library Catalogue - OPAC The ‘Refine your search’ heading is not logical because it increases by more than one heading level. This means that screen reader users may not be able to determine the structure of content on the page. 1/ Search for an item 3/ The resultant page contains a 'Regine your search' box containing filters. Current Code: <h4><a href="#" class="menu-collapse-toggle">Refine your search</a></h4> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 [Bug 25150] Accessibility: 2.4.10 Section Headings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25155 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25237 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105726&action=edit Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105727&action=edit Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105728&action=edit Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105726|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105729&action=edit Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105727|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105730&action=edit Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105728|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105731&action=edit Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105729|0 |1 is obsolete| | --- Comment #7 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 105760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105760&action=edit Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105730|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 105761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105761&action=edit Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105731|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 105762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105762&action=edit Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105760|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106119&action=edit Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105761|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106120&action=edit Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105762|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106121&action=edit Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in| |19.11.08 CC| |aleisha@catalyst.net.nz --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08 |19.11.08, 19.05.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org