[Bug 8128] New: can't seem to run new sql reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Priority: P5 - low Change sponsored?: --- Bug ID: 8128 Assignee: gmcharlt@gmail.com Summary: can't seem to run new sql reports Severity: blocker Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Reports Product: Koha I'm on master. I paste this to create an sql report. select count(*) as circs from statistics where type in ('issue','localuse') and datetime between <<Circed between (yyyy-mm-dd)>> and <<and (yyyy-mm-dd)>> It appears to save. I click 'Run Report' at the top and get this: Software error: execute_query failed to return sth for report : at /home/nengard/kohaclone/reports/guided_reports.pl line 602. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. When I go back the report did not save. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- The reports aren't getting saved: guided_reports.pl: DBD::mysql::db do failed: Column 'cache_expiry' cannot be null at /home/koha/kohaclone/C4/Reports/Guided.pm line 480., referer: http://kohadev:8080/cgi-bin/koha/reports/guided_reports.pl?phase=Create%20re... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9648&action=edit Bug 8128 - can't seem to run new sql reports Reports cannot be saved because saved_sql.cache_expiry cannot be null. Fixed by setting default to 0 if a cache_expiry value is not passed into the function. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9648|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9649&action=edit [SIGNED-OFF] Bug 8128 - can't seem to run new sql reports Reports cannot be saved because saved_sql.cache_expiry cannot be null. Fixed by setting default to 0 if a cache_expiry value is not passed into the function. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9649|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 9650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9650&action=edit Bug 8128 - can't seem to run new sql reports Reports cannot be saved because saved_sql.cache_expiry cannot be null. Fixed by setting default to 0 if a cache_expiry value is not passed into the function. Signed-off-by: Liz Rea <wizzyrea@gmail.com> passes t xt Verified original bug, patch resolves issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #5 from Magnus Enger <magnus@enger.priv.no> --- I think this is related to: Bug 7248 - Caching for services Bug 7249 - Report webservices The latter got pushed, but the former has gone through some iterations. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #5)
I think this is related to:
Bug 7248 - Caching for services Bug 7249 - Report webservices
The latter got pushed, but the former has gone through some iterations.
They've both been pushed, but somewhere in the process the database update got changed. Kyle came up with a fix that doesn't require a database update, which is what Nicole and Liz signed off on. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 --- Comment #7 from Magnus Enger <magnus@enger.priv.no> --- Ah, sorry, I was a bit too quick there... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Kyle, Why do you initialize the cache expiry with 0 whereas the field in DB have a default value = 300 ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 --- Comment #9 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9698&action=edit Bug 8128 - Followup - Change default value for cache_expiry Change default value for cache_expiry from 0 to 300. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 --- Comment #10 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to comment #8)
Hi Kyle, Why do you initialize the cache expiry with 0 whereas the field in DB have a default value = 300 ?
I was not aware of the default. I've submitted a followup to fix this. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9698|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9736&action=edit Bug 8128 - [SIGNED-OFF]Followup - Change default value for cache_expiry Change default value for cache_expiry from 0 to 300. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #12 from Ian Walls <koha.sekjal@gmail.com> --- Adds a default value for an otherwise-possibly-NULL field. marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 Blocks| |7249 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8128 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org