[Bug 6751] New: Link in readingrec.pl to export a barcode file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Bug #: 6751 Summary: Link in readingrec.pl to export a barcode file Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: jonathan.druart@biblibre.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com In the "Circulation History" tab, it should be possible to export a file containing a list of checkin barcode for the current day. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |jonathan.druart@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> 2011-08-19 09:55:03 UTC --- Created attachment 5056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5056 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 laurenthdl <henridamien.laurent@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |henridamien.laurent@biblibr | |e.com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Patch Status|Needs Signoff |Does not apply --- Comment #2 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-12-02 13:45:06 UTC --- $ git-bz apply 6751 Bug 6751 - Link in readingrec.pl to export a barcode file Proposed patch Apply? [yn] y Applying: Bug 6751: Adds a link "Export checkin barcodes" in readingrec error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt:31 error: koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt: patch does not apply error: patch failed: members/readingrec.pl:29 error: members/readingrec.pl: patch does not apply Patch failed at 0001 Bug 6751: Adds a link "Export checkin barcodes" in readingrec When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Proposed-patch-dq1fbK.patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff --- Comment #3 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-12-02 14:51:34 UTC --- Forget it, applies well with a 3-way merge in git bz (In reply to comment #2) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Does not apply --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-21 07:17:12 UTC --- Does not apply to current master (using git am -i3u) Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6751: Adds a link "Export checkin barcodes" in readingrec Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt Auto-merging members/readingrec.pl Failed to merge in the changes. Patch failed at 0001 Bug 6751: Adds a link "Export checkin barcodes" in readingrec When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5056|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-01-02 12:30:16 UTC --- Created attachment 7012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7012 rebased patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7012|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-13 07:54:19 UTC --- Created attachment 7130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7130 Bug 6751: Adds a link "Export checkin barcodes" in readingrec to export a file containing a list of checkin barcode for the current day. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 16:36:27 UTC --- QA comment: perlcritic failure. * perlcritic is OK before the patch * after the patch: perlcritic members/readingrec.pl I/O layer ":utf8" used at line 95, column 5. Use ":encoding(UTF-8)" to get strict validation. (Severity: 5) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-01-18 09:16:52 UTC --- Created attachment 7211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7211 Bug 6751 Remplace encoding mode for perlcritic This patch replaces binmode( STDOUT, ":utf8" ); with binmode( STDOUT, ":encoding(UTF-8)"); -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-01 17:28:59 UTC --- The patch does not apply anymore, because of a conflict with Datatables patch that has been pushed (bug 6836) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7130|0 |1 is obsolete| | Attachment #7211|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-10 10:20:14 UTC --- Created attachment 7561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7561 Rebased and Squashed version Bug 6751: Adds a link "Export checkin barcodes" in readingrec to export a file containing a list of checkin barcode for the current day. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P2 Status|Signed Off |Failed QA --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-15 08:51:29 UTC --- QA comment: * the code itself is OK * percritic still OK after patch applied One thing that make me mark "failed QA" though: 1- the description is "Export checkin barcodes". I can't see anywhere that it's related to "today" checked-in barcode. We will get new bug entries for this "bug". Please rename to "Export today checkin barcodes" & add some information to online help (koha-tmpl/intranet-tmpl/prog/en/help/members/readingrec.pl) 2- Last comment: the link is alone on readingrec.pl. I think it would be better to add it as an option in the "More" toolbar. Marking failed QA for #1, but as you'll submit a new patch, please also fix #2, it will be more graphically consistent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-15 11:47:56 UTC --- Created attachment 7651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7651 Bug 6751 Followup Move export action into the More toolbar This patch move the export into the "more" toolbar. We can export from the following pages: circ/circulation.pl members/notices.pl members/readingrec.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Version|rel_3_6 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7561|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8001&action=edit Bug 6751: Adds a link "Export checkin barcodes" in readingrec to export a file containing a list of checkin barcode for the current day. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7651|0 |1 is obsolete| | --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8002&action=edit Bug 6751: Followup: Move export action into the "More" toolbar Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Also corrected grammar: changed caption from "Export today checkin barcodes" to the more idiomatic "Export today's checked in barcodes." -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |koha.sekjal@gmail.com --- Comment #15 from Ian Walls <koha.sekjal@gmail.com> --- $delimiter is defined as ":", then immediately redefined as "\n". This seems unintentional... Also a small grammatical error in the followup patch: You can export the today checkin barcodes by... Easy enough fixes, but marking as Failed QA until they're resolved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8059&action=edit Bug 6751 Followup minors fixes -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8001|0 |1 is obsolete| | Attachment #8002|0 |1 is obsolete| | Attachment #8059|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8124&action=edit [SIGNED-OFF] Bug 6751: Adds a link "Export checkin barcodes" in readingrec to export a file containing a list of checkin barcode for the current day. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Ian Walls <koha.sekjal@gmail.com> --- Fixes issues I noticed in QA. Marking as Passed now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8154 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org