[Bug 11629] New: Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Bug ID: 11629 Summary: Add ability to update not for loan status on checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some libraries would like to streamline the cataloging process my automatically updating notforloan values on checkin. For example, an item is set to notforloan of -1 ( ordered ). The item, is received, processed, and checked in for the first time before being shelved. The checkin automatically changes the nfl value from -1 to 0. The same workflow could be used for damaged items as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24848&action=edit Bug 11629 - Add ability to update not for loan status on checkin Some libraries would like to streamline the cataloging process my automatically updating notforloan values on checkin. For example, an item is set to notforloan of -1 ( ordered ). The item, is received, processed, and checked in for the first time before being shelved. The checkin automatically changes the nfl value from -1 to 0. The same workflow could be used for damaged items as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateNotForLoanStatusOnCheckin to the following: -1: 0 0: 1 4) Create an item, set it's notforloan value to -1 5) Check in the item, note its not for loan value is now 0 6) Check in the item again, note its not for loan value is now 1 7) Check in the item again, note its not for loan value reamins 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24848|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24849&action=edit Bug 11629 - Add ability to update not for loan status on checkin Some libraries would like to streamline the cataloging process my automatically updating notforloan values on checkin. For example, an item is set to notforloan of -1 ( ordered ). The item, is received, processed, and checked in for the first time before being shelved. The checkin automatically changes the nfl value from -1 to 0. The same workflow could be used for damaged items as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateNotForLoanStatusOnCheckin to the following: -1: 0 0: 1 4) Create an item, set it's notforloan value to -1 5) Check in the item, note its not for loan value is now 0 6) Check in the item again, note its not for loan value is now 1 7) Check in the item again, note its not for loan value reamins 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Havilah Lyon <havilah@aflibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |havilah@aflibrary.org --- Comment #3 from Havilah Lyon <havilah@aflibrary.org> --- I tested this. It works fine for us. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24849|0 |1 is obsolete| | --- Comment #4 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 24962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24962&action=edit Bug 11629 - Add ability to update not for loan status on checkin -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24963&action=edit Bug 11629 [QA Followup] - Add message for librarian that status was updated -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24963|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24964&action=edit Bug 11629 [QA Followup] - Add message for librarian that status was updated -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, 2 things: - Can you please move the syspref so the alphabetic order is correct? - Are you very attached to the <strong> around the not for loan values in the librarian message? It breaks the string into pieces in translation: msgid "Not for loan status updated from " And somewhere a 'to' I was too lazy to locate. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: 1/ I am not sure the code you added to AddReturn is put at the right place. I think the code should be put into the if ( $doreturn ) statement (if the return is not done, I suppose we don't want to update the not for loan status). Moreover, you will be able to use the existing call to ModItem (and avoid 1 call to it). 2/ Could you add unit tests for this new syspref please? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25229&action=edit Bug 11629 [QA Followup 2] - Move code to inside of doreturn if statement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24962|0 |1 is obsolete| | Attachment #24964|0 |1 is obsolete| | Attachment #25229|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25580&action=edit Bug 11629 - Add ability to update not for loan status on checkin Some libraries would like to streamline the cataloging process my automatically updating notforloan values on checkin. For example, an item is set to notforloan of -1 ( ordered ). The item, is received, processed, and checked in for the first time before being shelved. The checkin automatically changes the nfl value from -1 to 0. The same workflow could be used for damaged items as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateNotForLoanStatusOnCheckin to the following: -1: 0 0: 1 4) Create an item, set it's notforloan value to -1 5) Check in the item, note its not for loan value is now 0 6) Check in the item again, note its not for loan value is now 1 7) Check in the item again, note its not for loan value reamins 1 Signed-off-by: Havilah Lyon <havilah@aflibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25581&action=edit Bug 11629 [QA Followup] - Add message for librarian that status was updated -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25582&action=edit Bug 11629 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)
QA comment: 1/ I am not sure the code you added to AddReturn is put at the right place. I think the code should be put into the if ( $doreturn ) statement (if the return is not done, I suppose we don't want to update the not for loan status). Moreover, you will be able to use the existing call to ModItem (and avoid 1 call to it).
2/ Could you add unit tests for this new syspref please?
Marked as Failed QA.
I deprecated the patch for point 1, as we *do* want to update the not for loan status even if the return is not done. In fact, the primary reason for this is to cause a not for loan item to become for loan. I wasn't thinking when I wrote the qa followup! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25583&action=edit Bug 11629 [QA Followup] - Remove <strong> tags to ease translation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, some problems to fix here: FAIL t/db_dependent/Circulation_issue.t OK pod OK forbidden patterns FAIL valid "my" variable $biblionumber masks earlier declaration in same scope "my" variable $biblioitemnumber masks earlier declaration in same scope OK critic FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs UNIMARCAuthorityField100 is bad placed (see bug 10610) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27233&action=edit Bug 11629 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27244&action=edit Bug 11629 [QA Followup] - Updating notforloan to 0 gives no "to" status in message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27244|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27245&action=edit Bug 11629 [QA Followup] - Updating notforloan to 0 gives no "to" status in message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27245|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27246&action=edit Bug 11629 [QA Followup] - Updating notforloan to 0 gives no "to" status in message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27247&action=edit [PASSED QA] Bug 11629 - Add ability to update not for loan status on checkin Some libraries would like to streamline the cataloging process my automatically updating notforloan values on checkin. For example, an item is set to notforloan of -1 ( ordered ). The item, is received, processed, and checked in for the first time before being shelved. The checkin automatically changes the nfl value from -1 to 0. The same workflow could be used for damaged items as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateNotForLoanStatusOnCheckin to the following: -1: 0 0: 1 4) Create an item, set it's notforloan value to -1 5) Check in the item, note its not for loan value is now 0 6) Check in the item again, note its not for loan value is now 1 7) Check in the item again, note its not for loan value reamins 1 Signed-off-by: Havilah Lyon <havilah@aflibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing notes on last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27248&action=edit [PASSED QA] Bug 11629 [QA Followup] - Add message for librarian that status was updated Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27249&action=edit [PASSED QA] Bug 11629 [QA Followup] - Unit Tests Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27250&action=edit [PASSED QA] Bug 11629 [QA Followup] - Remove <strong> tags to ease translation Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27251&action=edit [PASSED QA] Bug 11629 [QA Followup] Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changed the syspref.sql file to remove one of the doubled up UNIMARCAuthrityField100 that slipped in with an earlier patch on this bug. Passes all tests and QA script, also t/db_dependent/Circulation_issue.t Tested with items that had - no notforloan value set - notforloan value not used in updateNotforLoanStatusOnCheckin - the notforloan value defined in UpdateNotForLoanStatusOnCheckin Also verified it works the same, when the item was checked out or not checked out on return. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27252&action=edit [PASSED QA] Bug 11629 [QA Followup] - Updating notforloan to 0 gives no "to" status in message Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25581|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27246|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25582|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | Status|Passed QA |Patch doesn't apply --- Comment #26 from Galen Charlton <gmcharlt@gmail.com> --- Patch does not apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27247|0 |1 is obsolete| | Attachment #27248|0 |1 is obsolete| | Attachment #27249|0 |1 is obsolete| | Attachment #27250|0 |1 is obsolete| | Attachment #27251|0 |1 is obsolete| | Attachment #27252|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28147&action=edit Bug 11629 - Add ability to update not for loan status on checkin Some libraries would like to streamline the cataloging process my automatically updating notforloan values on checkin. For example, an item is set to notforloan of -1 ( ordered ). The item, is received, processed, and checked in for the first time before being shelved. The checkin automatically changes the nfl value from -1 to 0. The same workflow could be used for damaged items as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateNotForLoanStatusOnCheckin to the following: -1: 0 0: 1 4) Create an item, set it's notforloan value to -1 5) Check in the item, note its not for loan value is now 0 6) Check in the item again, note its not for loan value is now 1 7) Check in the item again, note its not for loan value reamins 1 Signed-off-by: Havilah Lyon <havilah@aflibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing notes on last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28148&action=edit Bug 11629 [QA Followup] - Add message for librarian that status was updated Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28149&action=edit Bug 11629 [QA Followup] - Unit Tests Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28150&action=edit Bug 11629 [QA Followup] - Remove <strong> tags to ease translation Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28151&action=edit Bug 11629 [QA Followup] Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changed the syspref.sql file to remove one of the doubled up UNIMARCAuthrityField100 that slipped in with an earlier patch on this bug. Passes all tests and QA script, also t/db_dependent/Circulation_issue.t Tested with items that had - no notforloan value set - notforloan value not used in updateNotforLoanStatusOnCheckin - the notforloan value defined in UpdateNotForLoanStatusOnCheckin Also verified it works the same, when the item was checked out or not checked out on return. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28152&action=edit Bug 11629 [QA Followup] - Updating notforloan to 0 gives no "to" status in message Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #33 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 6382 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14576 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org