http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 40507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40507&action=edit Bug 14436 - Undefined $searchmember causing warns in C4/Utils/DataTables/Members.pm This patch sets $searchmember to an empty string to avoid warns. To test: 1) Go to Patrons (/cgi-bin/koha/members/members-home.pl) and pick any letter to 'Browse by last name' 2) Notice the warns in the error log 3) Apply patch 4) Reload page and pick a letter to browse by last name 5) Notice page still works but no warns in error log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 40799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40799&action=edit Bug 14436: Undefined $searchtype causing warns Don't forget to apply both patches and test for the first patch too! To test this patch: 1) Use Check out tab on search bar 'enter patron card number or partial name' 2) Notice warns 3) Apply patch and reload page (ie make new search) 4) Notice page still works but no warns -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Indranil Das Gupta from comment #4)

Hi Aleisha,

I feel these two one-liners should be squashed into one patch. What say?

Not only that, but I think you fixed them in the wrong place. These are parameters set at the beginning of the function. I would correct $searchmember after line 21. -- after looking further, bug 14344 corrected the issue with the second patch. As such, I am obsoleting the second patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40799|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40507|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40926&action=edit Bug 14436: Noisy warns in C4/Utils/DataTables/Members.pm TEST PLAN --------- 1) Backup the koha intranet error log. 2) Empty the koha intranet error log. 3) In staff client, go to Patrons (/cgi-bin/koha/members/members-home.pl) 4) Pick any letter to 'Browse by last name' -- koha intranet error log now has warns. -- the one of importance is the uninitalized value. 5) Empty the koha intranet error log. 6) apply this patch 7) Repeat steps 3 & 4. -- koha intranet error log does not contain the uninitialized value error. 8) run koha qa test tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40931|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40966&action=edit Bug 14436: Noisy warns in C4/Utils/DataTables/Members.pm TEST PLAN --------- 1) Backup the koha intranet error log. 2) Empty the koha intranet error log. 3) In staff client, go to Patrons (/cgi-bin/koha/members/members-home.pl) 4) Pick any letter to 'Browse by last name' -- koha intranet error log now has warns. -- the one of importance is the uninitalized value. 5) Empty the koha intranet error log. 6) apply this patch 7) Repeat steps 3 & 4. -- koha intranet error log does not contain the uninitialized value error. 8) run koha qa test tools. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.