[Bug 19919] New: Writing off a Lost Item Fee marks as "Paid for by patron"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Bug ID: 19919 Summary: Writing off a Lost Item Fee marks as "Paid for by patron" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lisetteslatah@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 70293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70293&action=edit An example A replacement copy was ordered for an item that was "long lost overdue" on a patron's account. The librarian wanted the old copy deleted from the system to keep the record clean. We checked in the item, marked it as lost, and then wrote off the fee associated with the item. Finally we reapplied the fee manually, no longer associated with the item. We noticed that at the point of the write off, the item gets a line that says paid for by (Patron name and barcode) DATE TIME. This also happens if the book is checked in and no longer marked as lost (say it was returned by the borrower so we wrote off the lost item fee.) The borrower has not paid for the book in either situation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Christopher Davis <cgdavis@uintah.utah.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgdavis@uintah.utah.gov --- Comment #1 from Christopher Davis <cgdavis@uintah.utah.gov> --- Thanks Lisette, We have seen this behavior in Koha at our institution as well. This bug is more annoying and confusing than anything, but it would be good to have it patched. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com | |, | |kelly@bywatersolutions.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com Severity|enhancement |major --- Comment #2 from Barton Chittenden <barton@bywatersolutions.com> --- Marking as major, simply because this is going to cause a lot of confusion; I foresee many support tickets. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What could be a solution? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think that might be some underdocumented feature here that doesn't work in all cases. The message is set by ReturnLostItem: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Circulation.pm;... ReturnLostItem is only used by pay (at least in master): http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/Account.pm;hb... Then there is also the template: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet... So when a fine of type L or Rep is paid, the line will be added to items.paidfor. Of course this is problematic in multiple ways: - the whole note is untranslatable - we store firstname surname and not the borrowernumber, which can lead to confusion with common names. - we store a badly formatted date (note the missing leading zeros) in ISO format. We could fix the behaviour and only add the note for payments (not write offs). But maybe we should rethink the whole thing? Is this information really helpful when you can get it from the cleaned up accountlines and account_offsets table now in a clean way? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Edie Discher <edischer@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Storing this info on the item level is also problematic in light of GDPR. Can anyone describe a use case for storing this info in items.paidfor? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Magnus Enger from comment #5)
Storing this info on the item level is also problematic in light of GDPR.
Can anyone describe a use case for storing this info in items.paidfor?
Good point, totally agree. We should not store patron information like names in item data ever, there is too much risk in exporting the data in some way or making it accidentally visible in the OPAC. I'd vote for removing it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #6)
(In reply to Magnus Enger from comment #5)
Storing this info on the item level is also problematic in light of GDPR.
Can anyone describe a use case for storing this info in items.paidfor?
Good point, totally agree. We should not store patron information like names in item data ever, there is too much risk in exporting the data in some way or making it accidentally visible in the OPAC.
I'd vote for removing it.
+1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Magnus Enger from comment #5)
Can anyone describe a use case for storing this info in items.paidfor?
I found that: 2001-05-17 15:36 rangi * database.mysql: Changed the interim field in the items table, to be paidfor The horowhenua librarians wanted a place to store information when a lost item was paid for. The information is removed if the item is ever returned. The interim field was a hangover from the previous system and wasnt be used so I stole it :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12817 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #9 from George Williams (NEKLS) <george@nekls.org> --- I'm in favor of removing this altogether if it's not needed. If it is needed, then I'd like to see the patron information stored as the patron's borrowernumber of barcode number rather than as their name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to George Williams (NEKLS) from comment #9)
I'm in favor of removing this altogether if it's not needed.
If it is needed, then I'd like to see the patron information stored as the patron's borrowernumber of barcode number rather than as their name.
Never a barcode. It should be the borrowernumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 robbinsk@middlesex.mass.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robbinsk@middlesex.mass.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 12817 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 18868 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89320&action=edit Bug 19919: Do not record payments for a writeoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I need some guidance here. I've attached a basic patch to resolve just the problem as described in the title of the bug.. However, it looks like people are also very keen to remove this paidfor field entirely (which is actually pretty simple to do at this point and would not lose any information as we already store enough data to reconstruct it via the accountlines). So, as far as I can see there are two use cases for it, the first is for display in the item moredetails view (Does it matter if an item has been paid for, then returned and written off.. right now we remove the detail in paidfor so we don't display anything at this point, but we could show the payment and refund if we were so inclined) The second use case is for reports. This one is more challenging, we can't easily know what reports are out there in the wild so the best we can really do is advise as to how to get the same information back via a join to the accountlines table. Any guidance as to what we would hope to achieve in the long run would be greatly appreciated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Martin, the patch does not apply: error: sha1 information is lacking or useless (C4/Circulation.pm). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89320|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89356&action=edit Bug 19919: Do not record payments for a writeoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've uploaded a refreshed patch freshly based against master. I've not written a test for it yet - I wasn't sure whether this was actually what people wanted here (and to split out the removal of paidfor as a separate bug) or not.. so it's more of a proof of concept at this point. A test should however be pretty simple should we want to follow this route. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #18 from Liz Rea <wizzyrea@gmail.com> --- I confirm that this works, but I'd like to hear from Chris if Horowhenua Libraries still require this functionality before we totally get rid of it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Liz Rea from comment #18)
I confirm that this works, but I'd like to hear from Chris if Horowhenua Libraries still require this functionality before we totally get rid of it.
Adding him as CC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> --- They still use it, so if it could be fixed rather than removed would be great. Always a shame when we break things the Original Koha library use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Chris Cormack from comment #20)
They still use it, so if it could be fixed rather than removed would be great. Always a shame when we break things the Original Koha library use.
Just to clarify, this patch only corrects the behaviour to not record 'paidfor' when the action is a writoff rather than a payment. So, if I go ahead and write the tests for that here we should be good for this bug. For a follow-up bug I believe people are interested in cleaning up the implimentation somewhat to fit with more recent practice. Might pick your brains as to how this is used at Horowhenua some point soon Chris, be interested to fully understand the use cases before diving in. As I said before, I'm confident we can still get all the data out but I don't want to miss something or reduce usability uneccesarily -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- My concerns here are the issues of translatability and privacy. We store a patron name in items... which we expose for export practically everywhere. I think it would be really nice to keep the information, but in another database table. As it's mapped in MARC excluding it everywhere might turn out a bit of a never-ending chase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would moving it out of items be ok? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89459&action=edit Bug 19919: Stop using paidfor altogether -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, the second patch is an alternative `Stop using paidfor altogether` (or beginning of one which I would like some feedback on). This version removes the use of paidfor in the code entirely and instead derives the information for display within moredetails.pl (which is the only place I could find that it's displayed to the end users). I noticed whilst doing this that we also ship with the option LOST authorized value of 'Lost and Paid for'.. should we not set that status as part of the payment routine as part of this perhaps too? I've not added the code to actually remove the field yet (or the proper tests) as it's only a proof of concept at the minute which I'm seeking feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89459|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89472&action=edit Bug 19919: Stop using paidfor altogether This patch removed references to setting and getting the items.paidfor field. Where it was used for display, in moredetail.pl, we replace it with a query on the accountlines. Test plan: 1) Apply patch 2) Pay off a LOST item 3) Check for the associated display of 'Paidfor?:' on the itemdetails page 4) Writeoff a LOST item 5) Check that a 'Paidfor?:' is not displayed on the itemdetails page. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #27 from George Williams (NEKLS) <george@nekls.org> --- (In reply to Chris Cormack from comment #20)
They still use it, so if it could be fixed rather than removed would be great. Always a shame when we break things the Original Koha library use.
My objection is storing the patron's name. If this could store the borrowernumber instead, that would be OK by me, but using the patron's name is a privacy issue for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to George Williams (NEKLS) from comment #27)
(In reply to Chris Cormack from comment #20)
They still use it, so if it could be fixed rather than removed would be great. Always a shame when we break things the Original Koha library use.
My objection is storing the patron's name. If this could store the borrowernumber instead, that would be OK by me, but using the patron's name is a privacy issue for me.
So, the final patch here drops the need for the field entirely and instead queries the data from the accountlines instead. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #29 from Liz Rea <wizzyrea@gmail.com> --- The only problem i see here is that when we delete the patron, this paid for record will go away? or will it not I can't remember if we delete the accountlines when we delete a patron. Anyway it seems to work, and I'll sign off on it once you get a test for your new sub, providing everyone is OK with how it works now. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Liz Rea from comment #29)
The only problem i see here is that when we delete the patron, this paid for record will go away? or will it not I can't remember if we delete the accountlines when we delete a patron. Anyway it seems to work, and I'll sign off on it once you get a test for your new sub, providing everyone is OK with how it works now. :)
It used to go away, but we fixed that (it broke the accounting reports - mean). It should now set to NULL. I think as we can only delete a patron that has paid off all their fines, this should be ok? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So... are we close to a signoff.. I'm not sure how to read the last comments? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- If I get a signoff that the concept is right, I'll throw together the outstanding unit test quickly for the QA step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #33 from Liz Rea <wizzyrea@gmail.com> --- GO GO UNIT TEST MASTAH. :D We think the concept is good afaict. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Liz Rea <wizzyrea@gmail.com> --- Waiting for the promised tests (I know you are busy!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89472|0 |1 is obsolete| | --- Comment #35 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89794&action=edit Bug 19919: Stop using paidfor altogether This patch removed references to setting and getting the items.paidfor field. Where it was used for display, in moredetail.pl, we replace it with a query on the accountlines. Test plan: 1) Apply patch 2) Pay off a LOST item 3) Check for the associated display of 'Paidfor?:' on the itemdetails page 4) Writeoff a LOST item 5) Check that a 'Paidfor?:' is not displayed on the itemdetails page. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89794|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89814&action=edit Bug 19919: Stop using paidfor altogether This patch removed references to setting and getting the items.paidfor field. Where it was used for display, in moredetail.pl, we replace it with a query on the accountlines. Test plan: 1) Apply patch 2) Pay off a LOST item 3) Check for the associated display of 'Paidfor?:' on the itemdetails page 4) Writeoff a LOST item 5) Check that a 'Paidfor?:' is not displayed on the itemdetails page. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89815&action=edit Bug 19919: Unit Tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89814|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89816&action=edit Bug 19919: Stop using paidfor altogether This patch removed references to setting and getting the items.paidfor field. Where it was used for display, in moredetail.pl, we replace it with a query on the accountlines. Test plan: 1) Apply patch 2) Pay off a LOST item 3) Check for the associated display of 'Paidfor?:' on the itemdetails page 4) Writeoff a LOST item 5) Check that a 'Paidfor?:' is not displayed on the itemdetails page. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89815|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89817&action=edit Bug 19919: Unit Tests This patch adds unit tests for the addition of a patron accessor to the Koha::Account::Line object. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Depends on NSO. Please reset BLOCKED status as dependency has been signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89816|0 |1 is obsolete| | Attachment #89817|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 90228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90228&action=edit Bug 19919: Stop using paidfor altogether This patch removed references to setting and getting the items.paidfor field. Where it was used for display, in moredetail.pl, we replace it with a query on the accountlines. Test plan: 1) Apply patch 2) Pay off a LOST item 3) Check for the associated display of 'Paidfor?:' on the itemdetails page 4) Writeoff a LOST item 5) Check that a 'Paidfor?:' is not displayed on the itemdetails page. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90228|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 90229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90229&action=edit Bug 19919: Stop using paidfor altogether This patch removed references to setting and getting the items.paidfor field. Where it was used for display, in moredetail.pl, we replace it with a query on the accountlines. Test plan: 1) Apply patch 2) Pay off a LOST item 3) Check for the associated display of 'Paidfor?:' on the itemdetails page 4) Writeoff a LOST item 5) Check that a 'Paidfor?:' is not displayed on the itemdetails page. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 90230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90230&action=edit Bug 19919: Unit Tests This patch adds unit tests for the addition of a patron accessor to the Koha::Account::Line object. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22982 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- I think Kyle Qaed? marking as such -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |11573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 [Bug 11573] Fine descriptions related to Rentals are untranslatable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #46 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 22563 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #47 from Magnus Enger <magnus@libriotech.no> --- As far as I can tell, this does not remove values that are already in items.paidfor. Should we at least add a note somewhere (release notes?) to say that libraries need to run something like UPDATE items SET items.paidfor = '' to clean up old data? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Bug 19919 depends on bug 22563, which changed state. Bug 22563 Summary: Convert lost handling to use 'status' instead of multiple accounttypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@koha-us.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26012 [Bug 26012] Date in 'Paid for' information not formatted to Time/DateFormat system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 [Bug 26268] Remove items.paidfor once and for all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38787 [Bug 38787] "Paid for?" message in item info lists patrons who did not pay for item -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org